Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change versioning #549

Open
kelle opened this issue Aug 12, 2024 · 10 comments
Open

Change versioning #549

kelle opened this issue Aug 12, 2024 · 10 comments

Comments

@kelle
Copy link
Collaborator

kelle commented Aug 12, 2024

Consider changing version scheme from YYYY.n to N.yyyy.m, where N is the structure version and yyyy.m is for data updates. If the schema changes, we increase N. If we add more data, we increase m.

@kelle
Copy link
Collaborator Author

kelle commented Oct 1, 2024

Also need to add a number for when the software (simple/utils) changes!

N - schema
X - software??
YYYY.m - data

N.X.YYYY.m?

Let's think on this.

@dr-rodriguez
Copy link
Collaborator

Discussing it further, I agree with N.X.YYYY.m

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

So, if we were to release today, it would be 1.1.2024.7.

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

another option, with lots of text: schema.1-simple.1-data.2024.7

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

or
1-1-2024.7
or
2024.7-1-1

We think schema should go first because it's the most breaking change.

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

waiting for #558 and pyproject.toml first.

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

Hm, maybe we don't want to use dashes: pypa/setuptools-scm#825

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

Due to the trouble with the dashes, we went with periods:
1.1.2024.7

@kelle
Copy link
Collaborator Author

kelle commented Oct 15, 2024

@kelle kelle closed this as completed Oct 15, 2024
@kelle
Copy link
Collaborator Author

kelle commented Nov 13, 2024

This page has a lot of useful info which would have helped this discussion: https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers. Reopening just to make sure we don't want to change our mind after reading.

@kelle kelle reopened this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants