Skip to content
This repository has been archived by the owner on Jun 15, 2020. It is now read-only.

Generated definitions are not usable in a browser #22

Open
tamird opened this issue Mar 21, 2017 · 0 comments
Open

Generated definitions are not usable in a browser #22

tamird opened this issue Mar 21, 2017 · 0 comments

Comments

@tamird
Copy link
Contributor

tamird commented Mar 21, 2017

Broken in 0c90364. That commit introduced hardcoded references to Buffer which is not defined in browsers, breaking Proto2TypeScript for non-Node environments.

From #13 (comment):

But we should definitely fix that. The flag to enable the node-only definitions is a good idea. The tests could also be improved, they were develop when I was the single user of the project, and they are far from perfect.

@kalbasit @yellowiscool

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant