Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pydantic model for GitLabUserInfo is too strict #83

Closed
CasperWA opened this issue Feb 3, 2024 · 0 comments · Fixed by #88
Closed

The pydantic model for GitLabUserInfo is too strict #83

CasperWA opened this issue Feb 3, 2024 · 0 comments · Fixed by #88
Assignees
@CasperWA
Labels
bug Something isn't working Pydantic models Related to the pydantic models Service Related to the REST API Service

Comments

@CasperWA
Copy link
Collaborator

CasperWA commented Feb 3, 2024

Some of the fields should be optional with a default value given. If this is too strict, validation will fail without a proper message given to the user.
@CasperWA CasperWA added bug Something isn't working Service Related to the REST API Service Pydantic models Related to the pydantic models labels Feb 3, 2024
@CasperWA CasperWA mentioned this issue Feb 12, 2024
Merged
@CasperWA CasperWA self-assigned this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working Pydantic models Related to the pydantic models Service Related to the REST API Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up authorization models SINTEF/entities-service
1 participant
@CasperWA