Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Java ExtractorCLI with equivalent C# service #696

Closed
rkm opened this issue Apr 1, 2021 · 0 comments · Fixed by #702
Closed

Replace Java ExtractorCLI with equivalent C# service #696

rkm opened this issue Apr 1, 2021 · 0 comments · Fixed by #702
Assignees

Comments

@rkm
Copy link
Member

rkm commented Apr 1, 2021

The purpose of the ExtractorCLI tool is to kick-start an extraction request by reading a CSV file and some CLI arguments, and sending a few RabbitMQ messages.

Currently this is implemented in Java which, although it is functional, has a few maintainability issues:

  • Duplication of message classes between C#/Java which require to be updated in sync
  • Requires a separate application to be deployed instead of being bundled in the single smi script
  • Our developers are less familiar with the Java ecosystem, and so that part of the repo is more susceptible to bit-rot

I don't see any strong reason why we shouldn't replace the Java service with an equivalent C# implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant