Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URRS: don't reformat posts/xxx/timeline links #167

Open
tripleee opened this issue Jun 19, 2019 · 4 comments
Open

URRS: don't reformat posts/xxx/timeline links #167

tripleee opened this issue Jun 19, 2019 · 4 comments

Comments

@tripleee
Copy link
Contributor

tripleee commented Jun 19, 2019

The option "Change bare question URLs to the question's title." should arguably not change links which are not links to questions.

Currently it does this for timeline links, such as https://chat.stackoverflow.com/transcript/message/46547750#46547750, as shown in this screen shot of how my Chrome renders that chat message:

Screenshot 2019-06-19 at 21 59 23

The actual link in that message is https://stackoverflow.com/posts/56645139/timeline

I have not examined the source code to pinpoint the place where this is happening. I'm thinking anything which ends with /timeline should be easy to exclude, though I imagine there might be other patterns which should be added as well. (Resisting the urge. Wait, oops.)

@makyen
Copy link
Contributor

makyen commented Jun 19, 2019

I'm more inclined to have the link text change to "Timeline for: Is there a function to check the continuity in a list?", rather than not change the link text at all. Assuming that was the resolution, I'd call this more an enhancement rather than a bug, but I could see it both ways.

@makyen makyen self-assigned this Jun 19, 2019
@tripleee
Copy link
Contributor Author

No objection, though then the option should perhaps be relabelled to reflect its wider scope...?

@makyen
Copy link
Contributor

makyen commented Jun 19, 2019

Does the following changed text meet your expectations:

URRS changes to timeline, revisions, edit bare URLs

I'll also change the wording on that option.

@tripleee
Copy link
Contributor Author

Looking good, yeah. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants