Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SORMAS2SORMAS] Resending data in bulk edit mode fails with unclear generic error message #4190

Closed
Tracked by #10739
kwa20 opened this issue Jan 31, 2021 · 3 comments
Assignees
Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) integration Integration with external systems s2s Issues related to the SORMAS2SORMAS functionality

Comments

@kwa20
Copy link

kwa20 commented Jan 31, 2021

Bug Description

When data was already shared with another instance, resending it through the bulk edit mode does not work and results in an error 400. I believe this problem occurs because the system tries to go through the share functionality again rather than sync instead.

Steps to Reproduce

  1. Select an already shared case in the bulk edit mode in the cases directory and try resending it to the same instance.

Expected Behavior

When trying to share a case with the same instance again through the bulk edit function, the case should sync the data previously sent to this instance.

Screenshots

Screen Shot 2021-01-31 at 4 19 37 PM

Screen Shot 2021-01-31 at 4 16 46 PM

Screen Shot 2021-01-31 at 4 19 25 PM

System Details

  • Device:
  • SORMAS version: 1.54.1
  • Android version/Browser: chrome
  • Server URL: test1402.sormas-oegd.de
  • User Role: admin, national user

Additional Information

@kwa20 kwa20 added the bug An error or misbehavior of an existing feature (ticket type) label Jan 31, 2021
@MateStrysewske MateStrysewske added this to the Sprint 99 - 1.55.0 milestone Feb 1, 2021
@MateStrysewske MateStrysewske added integration Integration with external systems backend Affects the web backend labels Feb 1, 2021
@vidi42 vidi42 removed this from the Sprint 99 - 1.55.0 milestone Feb 2, 2021
@markusmann-vg markusmann-vg added this to the Sprint 101 - 1.58.0 milestone Feb 26, 2021
@leventegal-she leventegal-she self-assigned this Mar 10, 2021
@leventegal-she
Copy link
Contributor

leventegal-she commented Mar 10, 2021

I wouldn't consider not syncing in bulk is a bug. Syncing in bulk is not yet implemented.

The bug I see in this ticket is the error popup that displays "400 bad request" but it should show more relevant message like "the case already exists" but I couldn't reproduce this.

Some more details are needed about the context, what options where checked, is it sure that the case was shared already. maybe some details about the shared data: an export csv would help a lot.

@kwa20 Can you please provide some details to reproduce this error message?


For handling sync in bulk mode I would suggest to create a new change/feature request and refine it because there are some open points that should be discussed:

  • share and sync work slightly different that's one reason it is separated on the details page
  • in bulk mode the user can select some shared cases but also some unshared => how to proceed in this case? should we separate the share and sync actions here too?
  • sync preselects previously used options => what options to reuse in bulk mode if some cases where shared with samples and others without samples

@markusmann-vg @MateStrysewske @MartinWahnschaffe

@MateStrysewske
Copy link
Contributor

@leventegal-she If bulk-resending isn't implemented yet, I agree that we should rather open a new feature request for it. Can you please rename this issue to match the actual bug that you've described?

@leventegal-she leventegal-she changed the title [SORMAS2SORMAS] Resending data does not work in bulk edit mode [SORMAS2SORMAS] Resending data in bulk edit mode fails with unclear generic error message Mar 11, 2021
@vidi42
Copy link
Contributor

vidi42 commented Mar 23, 2021

This generic error message was somehow already addressed with #4348 and it looks like this:
image

@kwa20 I suggest we close this issue and address the feature implementation of the Bulk Sync with #4858

@vidi42 vidi42 closed this as completed Mar 23, 2021
@SahaLinaPrueger SahaLinaPrueger added the s2s Issues related to the SORMAS2SORMAS functionality label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) integration Integration with external systems s2s Issues related to the SORMAS2SORMAS functionality
Projects
None yet
Development

No branches or pull requests

6 participants