Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic example now adds storage content, where none was before. #77

Open
ahobeost opened this issue Jun 25, 2024 · 1 comment
Open

Basic example now adds storage content, where none was before. #77

ahobeost opened this issue Jun 25, 2024 · 1 comment
Assignees

Comments

@ahobeost
Copy link
Contributor

ahobeost commented Jun 25, 2024

When comparing the results from before the many merges, with those after, the shSourceBus_building* tabs now include storage content.

Is this a desired change?

https://github.com/SPF-OST/optihood/tree/75-get-optihood-under-ci/tests/test_examples/expected_files
Compare test_run_basic_example.xls with 'test_results_basic_example_after_merge.xls'

This can also be done using:
test_compare_results_before_and_after_merge
https://github.com/SPF-OST/optihood/blob/75-get-optihood-under-ci/tests/test_examples/test_xls_examples.py

@ahobeost ahobeost assigned ahobeost and nehadimri1991 and unassigned ahobeost Jun 25, 2024
@ahobeost
Copy link
Contributor Author

The manual test simplifies the xls comparison using plots:
Given unequal dataframes.
A plot is shown with the two dataframes.
image

And, if the shape is equal, their differences.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants