Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New #define arguments #382

Closed
mathaym25 opened this issue Apr 4, 2020 · 2 comments
Closed

New #define arguments #382

mathaym25 opened this issue Apr 4, 2020 · 2 comments
Assignees
Labels
✨ feature New feature or request *released The changes has been released
Milestone

Comments

@mathaym25
Copy link
Contributor

It is very useful to be able to use #define for fakeplayers.
However, the only current way to do this is to put them in #define entity. But this implies that they are visible in the fields reserved for entities.
It could be useful to have a #define fakeplayer <name> <descritpion> which is self-completing only in the fields linked to the scores (execute if score <fakeplayer or entity> <score> for example)

It can also be useful to have a #define nbt to auto complete our custom structures in the tag:{} of items or storages. (#define nbt Foo:["this is","a test"] And this is a description for example)

But also, in certain cases, a #define path to auto complete with our structures the path arguments (for data modify for example).

@SPGoding
Copy link
Member

SPGoding commented Apr 4, 2020

I'd like to use #define score_holder (score_holder is the name of the parser that Minecraft uses internally) instead of #define fakeplayer.

NBT-related stuff still has to be considered since I have a plan for doc comment at #1. It probably won't come in the next version, sorry ;(

@SPGoding SPGoding self-assigned this Apr 4, 2020
@SPGoding SPGoding added the ✨ feature New feature or request label Apr 4, 2020
@SPGoding SPGoding added this to the Release 2.0.0 milestone Apr 4, 2020
@SPGoding
Copy link
Member

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SPGoding SPGoding added the *released The changes has been released label Apr 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature New feature or request *released The changes has been released
Projects
None yet
Development

No branches or pull requests

2 participants