Merge remote-tracking branch 'refs/remotes/origin/dev'

Author: BlitzErik

Diff for: .github/ISSUE_TEMPLATE.md

@@ -1,4 +1,5 @@
 **Do you want to request a *feature* or report a *bug*?**
+If you're reporting a bug, include the version number of the script you're using. If it's not the current version, upgrade to the current version and test that before reporting a bug - we fix a lot of stuff in each new build.
 
 **What is the current behavior?**
 

Diff for: Documentation/Development/ReleaseProcess.md

@@ -22,12 +22,16 @@ Well, useful is probably the wrong word. More like entertaining. Here we go.
     * Run _TestBed.sql: this has stored proc calls with common parameters. May have to add in new scenarios if new features are added. 
 * If it passes, bump all the version numbers inside the scripts.
     * sp_foreachdb (no version number yet)
+    * sp_BlitzTrace (no version number yet)
+    * sp-BlitzRS (no version number yet)
     * sp_BlitzWho @Version and @VersionDate
     * sp_BlitzIndex @Version and @VersionDate
     * sp_BlitzFirst @VersionDate (no version) 
     * sp_BlitzCache @Version and @VersionDate 
     * sp_Blitz @Version and @VersionDate
     * sp_DatabaseRestore @Version and @VersionDate
+    * sp_BlitzBackups @Version and @VersionDate
+    * sp_BlitzQueryStore @Version and @VersionDate
 
 ## Push to Master
 

Diff for: Documentation/Development/Test sp_DatabaseRestore.sql

@@ -0,0 +1,70 @@
+DECLARE @database_name NVARCHAR(MAX), @backup_path NVARCHAR(MAX), @i INT
+
+SET @database_name = 'ENTER YOUR DATABASE NAME'
+SET @backup_path = 'Path to your Ola Backups ROOT FOLDER (see the db name will be attached later)'
+SET @i = 0
+
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'FULL',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+
+/*Why do I add delays, IDK just wanted to make sure streams do not get crossed */
+WAITFOR DELAY '00:00:30'
+
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'DIFF',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+
+WAITFOR DELAY '00:00:30'
+
+WHILE (@i <= 10)
+BEGIN
+SET @i += 1
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'LOG',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+WAITFOR DELAY '00:00:03'
+END
+
+DECLARE @cmd NVARCHAR(4000), @BackupPathDiff NVARCHAR(MAX), @PointInTime NVARCHAR(4000), @full_path NVARCHAR(MAX), @diff_path VARCHAR(MAX), @log_path VARCHAR(MAX)
+DECLARE @FileList TABLE (BackupFile NVARCHAR(255))
+SET @full_path = @backup_path + '\' + @database_name + '\FULL\'
+SET @diff_path = @backup_path + '\' + @database_name + '\DIFF\'
+SET @log_path =  @backup_path + '\' + @database_name + '\LOG\'
+
+-- get list of files 
+SET @cmd = 'DIR /b "'+ @log_path + '"';
+INSERT INTO @FileList (BackupFile)
+EXEC master.sys.xp_cmdshell @cmd; 
+
+SET @PointInTime = (SELECT TOP 1 * FROM @FileList ORDER BY NEWID())
+SET @PointInTime = REPLACE(LEFT(RIGHT(@PointInTime, 19),15), '_', '')
+PRINT @full_path
+PRINT @diff_path
+PRINT @log_path
+
+EXEC dbo.sp_DatabaseRestore 
+	@Database = @database_name, 
+	@BackupPathFull = @full_path, 
+	@BackupPathDiff = @diff_path,
+	@BackupPathLog = @log_path, 
+	@RestoreDiff = 1,
+	@ContinueLogs = 0, 
+	@RunRecovery = 1,
+	@StopAt = @PointInTime,
+	@Debug = 1;

Diff for: README.md

@@ -17,6 +17,7 @@ Navigation
    - [Advanced sp_BlitzIndex Parameters](#advanced-sp_blitzindex-parameters)
  - [sp_BlitzFirst: Real-Time Performance Advice](#sp_blitzfirst-real-time-performance-advice)
    - [Advanced sp_BlitzFirst Parameters](#advanced-sp_blitzfirst-parameters)
+ - [sp_BlitzBackups](#sp-blitzbackups)  
  - [Parameters Common to Many of the Stored Procedures](#parameters-common-to-many-of-the-stored-procedures)
  - [License MIT](#license)
 
@@ -209,7 +210,7 @@ In addition to the [parameters common to many of the stored procedures](#paramet
 [*Back to top*](#header1)
 
 =======
-## DatabaseRestore: Easier Multi-File Restores
+## sp_DatabaseRestore: Easier Multi-File Restores
 
 If you use [Ola Hallengren's backup scripts](http://ola.hallengren.com), DatabaseRestore.sql helps you rapidly restore a database to the most recent point in time.
 
@@ -219,7 +220,7 @@ Parameters include:
 * @RestoreDatabaseName
 * @BackupPathFull
 * @BackupPathLog
-* @MoveFiles, @MOveDataDrive, @MoveLogDrive
+* @MoveFiles, @MoveDataDrive, @MoveLogDrive
 * @TestRestore
 * @RunCheckDB
 * @ContinueLogs
@@ -228,6 +229,43 @@ Parameters include:
 For information about how this works, see [Tara Kizer's white paper on Log Shipping 2.0 with Google Compute Engine.](https://BrentOzar.com/go/gce)
 >>>>>>> refs/remotes/origin/dev
 
+<<<<<<< HEAD
+[*Back to top*](#header1)
+
+=======
+## sp_BlitzBackups
+
+Checks your backups and reports estimated RPO and RTO based on historical data in msdb, or a centralized location for [msdb].dbo.backupset.
+
+Parameters include:
+
+* @HoursBack -- How many hours into backup history you want to go. Should be a negative number (we're going back in time, after all). But if you enter a positive number, we'll make it negative for you. You're welcome.
+* @MSDBName -- if you need to prefix dbo.backupset with an alternate database name. 
+* @AGName -- If you have more than 1 AG on the server, and you don't know the listener name, specify the name of the AG you want to use the listener for, to push backup data. This may get used during analysis in a future release for filtering.
+* @RestoreSpeedFullMBps --[FIXFIX] Brent can word this better than I can
+* @RestoreSpeedDiffMBps -- Nothing yet
+* @RestoreSpeedLogMBps -- Nothing yet
+
+* @PushBackupHistoryToListener -- Turn this to 1 to skip analysis and use sp_BlitzBackups to push backup data from msdb to a centralized location (more the mechanics of this to follow)
+* @WriteBackupsToListenerName -- This is the name of the AG listener, and **MUST** have a linked server configured pointing to it. Yes, that means you need to create a linked server that points to the AG Listener, with the appropriate permissions to write data.  
+* @WriteBackupsToDatabaseName -- This can't be 'msdb' if you're going to use the backup data pushing mechanism. We can't write to your actual msdb tables.
+* @WriteBackupsLastHours -- How many hours in the past you want to move data for. Should be a negative number (we're going back in time, after all). But if you enter a positive number, we'll make it negative for you. You're welcome.
+
+An example run of sp_BlitzBackups to push data looks like this:
+
+```
+EXEC sp_BlitzBackups    @PushBackupHistoryToListener = 1, -- Turn it on!
+                        @WriteBackupsToListenerName = 'AG_LISTENER_NAME', -- Name of AG Listener and Linked Server 
+                        @WriteBackupsToDatabaseName = 'FAKE_MSDB_NAME',  -- Fake MSDB name you want to push to. Remember, can't be real MSDB.
+                        @WriteBackupsLastHours = -24 -- Hours back in time you want to go
+```
+
+In an effort to not clog your servers up, we've taken some care in batching things as we move data. Inspired by Michael J. Swart (michaeljswart.com/2014/09/take-care-when-scripting-batches/), we only move data in 10 minute intervals.
+
+The reason behind that is, if you have 500 databases, and you're taking log backups every minute, you can have a lot of data to move. A 5000 row batch should move pretty quickly.
+	
+>>>>>>> refs/remotes/origin/dev
+
 ## Parameters Common to Many of the Stored Procedures
 
 * @Help = 1 - returns a result set or prints messages explaining the stored procedure's input and output. Make sure to check the Messages tab in SSMS to read it.

Diff for: sp_Blitz.sql

@@ -31,8 +31,8 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
-	SET @Version = '5.3';
-	SET @VersionDate = '20170501';
+	SET @Version = '5.4';
+	SET @VersionDate = '20170603';
 	SET @OutputType = UPPER(@OutputType);
 
 	IF @Help = 1 PRINT '
@@ -626,7 +626,7 @@ AS
 										AND d.name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 															FROM  #SkipChecks
-															WHERE CheckID IS NULL )
+															WHERE CheckID IS NULL OR CheckID = 1)
 										/*
 										The above NOT IN filters out the databases we're not supposed to check.
 										*/
@@ -683,7 +683,7 @@ AS
 										AND d.name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 															FROM  #SkipChecks
-															WHERE CheckID IS NULL )
+															WHERE CheckID IS NULL OR CheckID = 2)
 										AND NOT EXISTS ( SELECT *
 														 FROM   msdb.dbo.backupset b
 														 WHERE  d.name COLLATE SQL_Latin1_General_CP1_CI_AS = b.database_name COLLATE SQL_Latin1_General_CP1_CI_AS
@@ -1091,7 +1091,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 12)
 					END
 
 
@@ -1121,7 +1121,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL);
+														  WHERE CheckID IS NULL OR CheckID = 13);
 					END
 
 
@@ -1149,7 +1149,7 @@ AS
 					  FROM sys.databases
 					  WHERE page_verify_option < 2
 					  AND name <> ''tempdb''
-					  and name not in (select distinct DatabaseName from #SkipChecks) OPTION (RECOMPILE);'
+					  and name not in (select distinct DatabaseName from #SkipChecks WHERE CheckID IS NULL OR CheckID = 14) OPTION (RECOMPILE);'
 								EXECUTE(@StringToExecute)
 							END;
 					END
@@ -1181,7 +1181,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 15)
 					END
 
 				IF NOT EXISTS ( SELECT  1
@@ -1210,7 +1210,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 16)
 					END
 
 
@@ -1240,7 +1240,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 17)
 					END
 
 
@@ -1269,7 +1269,7 @@ AS
 								WHERE   is_parameterization_forced = 1
 										AND name NOT IN ( SELECT  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 18)
 					END
 
 
@@ -1299,7 +1299,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 20)
 					END
 
 
@@ -1328,7 +1328,7 @@ AS
 					  (''Database ['' + [name] + ''] has Transparent Data Encryption enabled.  Make absolutely sure you have backed up the certificate and private key, or else you will not be able to restore this database.'') AS Details
 					  FROM sys.databases
 					  WHERE is_encrypted = 1
-					  and name not in (select distinct DatabaseName from #SkipChecks) OPTION (RECOMPILE);'
+					  and name not in (select distinct DatabaseName from #SkipChecks WHERE CheckID IS NULL OR CheckID = 21) OPTION (RECOMPILE);'
 								EXECUTE(@StringToExecute)
 							END;
 					END
@@ -1692,7 +1692,8 @@ AS
 										AND DB_NAME(database_id) NOT IN (
 										SELECT DISTINCT
 												DatabaseName
-										FROM    #SkipChecks )
+										FROM    #SkipChecks
+										WHERE CheckID IS NULL OR CheckID = 26 )
 					END
 
 
@@ -2334,7 +2335,7 @@ AS
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL);
+														  WHERE CheckID IS NULL OR CheckID = 55);
 					END
 
 				IF NOT EXISTS ( SELECT  1
@@ -2440,7 +2441,7 @@ AS
 								WHERE   name NOT IN ( SELECT DISTINCT
 																DatabaseName
 													  FROM      #SkipChecks 
-													  WHERE CheckID IS NULL)
+													  WHERE CheckID IS NULL OR CheckID = 62)
 										AND compatibility_level <= 90
 					END
 
@@ -3016,7 +3017,7 @@ AS
 						                        AND d.name NOT IN ( SELECT DISTINCT
 													                        DatabaseName
 											                        FROM    #SkipChecks 
-																	WHERE CheckID IS NULL)
+																	WHERE CheckID IS NULL OR CheckID = 148)
 	                        END
 
                         /* Reliability - Database Files Stored in Azure */
@@ -3046,7 +3047,7 @@ AS
 						                        AND d.name NOT IN ( SELECT DISTINCT
 													                        DatabaseName
 											                        FROM    #SkipChecks 
-																	WHERE CheckID IS NULL)
+																	WHERE CheckID IS NULL OR CheckID = 149)
 	                        END
 
 
@@ -3899,7 +3900,7 @@ IF @ProductVersionMajor >= 10
 					AS Details
 			FROM    #dbcc_events_from_trace d
 			WHERE d.[dbcc_event_trunc_upper] NOT IN (
-			N'DBCC CHECKCB', N' DBCC CHECKALLOC' , N'DBCC CHECKTABLE', N'DBCC CHECKCATALOG', N'DBCC CHECKFILEGROUP', --CHECKDB related
+			N'DBCC CHECKDB', N' DBCC CHECKALLOC' , N'DBCC CHECKTABLE', N'DBCC CHECKCATALOG', N'DBCC CHECKFILEGROUP', --CHECKDB related
 			N'DBCC TRACEON', N'DBCC TRACEOFF', N'DBCC DBINFO', N'DBCC LOGINFO', N'DBCC INPUTBUFFER', N'DBCC TRACESTATUS', --Usually monitoring tool related
 			N'DBCC CHECKIDENT', N'DBCC SHOW_STATISTICS', N'DBCC CHECKCONSTRAINTS',  --Probably rational
 			N'DBCC CLEANTABLE', N'DBCC CHECKPRIMARYFILE', N'DBCC OPENTRAN', 'DBCC SHOWFILESTATS' --Weird but okay
@@ -4324,7 +4325,7 @@ IF @ProductVersionMajor >= 10
 								        WHERE   name NOT IN ( SELECT DISTINCT
 																        DatabaseName
 													          FROM      #SkipChecks 
-													          WHERE CheckID IS NULL)
+													          WHERE CheckID IS NULL OR CheckID = 19)
 										        AND is_published = 1
 										        OR is_subscribed = 1
 										        OR is_merge_published = 1
@@ -4695,7 +4696,7 @@ IF @ProductVersionMajor >= 10
 																AND dbname NOT IN ( SELECT DISTINCT
 																						  DatabaseName
 																					FROM  #SkipChecks 
-																					WHERE CheckID IS NULL)
+																					WHERE CheckID IS NULL OR CheckID = 72)
 												DROP TABLE #partdb
 											END
 
@@ -4903,7 +4904,7 @@ IF @ProductVersionMajor >= 10
 									FROM [?].sys.database_scoped_configurations dsc 
 									INNER JOIN #DatabaseScopedConfigurationDefaults def1 ON dsc.configuration_id = def1.configuration_id
 									LEFT OUTER JOIN #DatabaseScopedConfigurationDefaults def ON dsc.configuration_id = def.configuration_id AND (dsc.value = def.default_value OR dsc.value IS NULL) AND (dsc.value_for_secondary = def.default_value_for_secondary OR dsc.value_for_secondary IS NULL)
-									LEFT OUTER JOIN #SkipChecks sk ON def.CheckID = sk.CheckID AND (sk.DatabaseName IS NULL OR sk.DatabaseName = DB_NAME())
+									LEFT OUTER JOIN #SkipChecks sk ON (sk.CheckID IS NULL OR def.CheckID = sk.CheckID) AND (sk.DatabaseName IS NULL OR sk.DatabaseName = DB_NAME())
 									WHERE def.configuration_id IS NULL AND sk.CheckID IS NULL ORDER BY 1
 									 OPTION (RECOMPILE);';
 					        END
@@ -5360,7 +5361,7 @@ IF @ProductVersionMajor >= 10
 																  DatabaseName
 																FROM
 																  #SkipChecks 
-																WHERE CheckID IS NULL)
+																WHERE CheckID IS NULL OR CheckID = 68)
 											AND CONVERT(DATETIME, DB2.Value, 121) < DATEADD(DD,
 																  -14,
 																  CURRENT_TIMESTAMP)
@@ -5525,7 +5526,8 @@ IF @ProductVersionMajor >= 10
 										AND DB_NAME(a.database_id) NOT IN (
 										SELECT DISTINCT
 												DatabaseName
-										FROM    #SkipChecks )
+										FROM    #SkipChecks 
+										WHERE CheckID = 75 OR CheckID IS NULL)
 										AND a.size > 125000 /* Size is measured in pages here, so this gets us log files over 1GB. */
 										AND a.size > ( SELECT   SUM(CAST(b.size AS BIGINT))
 													   FROM     sys.master_files b
@@ -5565,7 +5567,7 @@ IF @ProductVersionMajor >= 10
 										AND name NOT IN ( SELECT DISTINCT
 																  DatabaseName
 														  FROM    #SkipChecks 
-														  WHERE CheckID IS NULL)
+														  WHERE CheckID IS NULL OR CheckID = 76)
 										AND collation_name <> ( SELECT
 																  collation_name
 																FROM
@@ -5601,10 +5603,9 @@ IF @ProductVersionMajor >= 10
 								FROM    sys.databases dSnap
 										INNER JOIN sys.databases dOriginal ON dSnap.source_database_id = dOriginal.database_id
 																  AND dSnap.name NOT IN (
-																  SELECT DISTINCT
-																  DatabaseName
-																  FROM
-																  #SkipChecks )
+																  SELECT DISTINCT DatabaseName
+																  FROM #SkipChecks 
+																  WHERE CheckID = 77 OR CheckID IS NULL)
 					END
 
 				IF NOT EXISTS ( SELECT  1