Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Live Share problems due to direct filesystem access #98

Open
SReichelt opened this issue Jan 17, 2021 · 0 comments
Open

Fix Live Share problems due to direct filesystem access #98

SReichelt opened this issue Jan 17, 2021 · 0 comments
Labels
bug Something isn't working component: vscode extension Issue concerns the Slate extension for Visual Studio Code

Comments

@SReichelt
Copy link
Owner

Some parts of the VSCode extension still access the filesystem directly via Node's fs module instead of using vscode.workspace.fs. This causes errors when using Live Share.

To change this, quite a bit of code must become asynchronous.

In the end, no more imports of the fs an slate-env-node modules should remain, and slate-env-node should be removed from src/vscode/package.json.
@SReichelt SReichelt added bug Something isn't working component: vscode extension Issue concerns the Slate extension for Visual Studio Code labels Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: vscode extension Issue concerns the Slate extension for Visual Studio Code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SReichelt