Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose logging enabled in RunCommandInternalRaw #106

Open
ccarvalheiro opened this issue Jun 14, 2019 · 3 comments
Open

Verbose logging enabled in RunCommandInternalRaw #106

ccarvalheiro opened this issue Jun 14, 2019 · 3 comments

Comments

@ccarvalheiro
Copy link
Contributor

ccarvalheiro commented Jun 14, 2019

In a recent commit, the logging in RunCommandInternalRaw was enabled by commenting #if UE_BUILD_DEBUG. See here and here.

Was this change made intentionally? It appears to slows down our mid sized projects and (Disregard this since it shouldn't have any significant impact on performance) Sometimes floods the log making it difficult to use.

@SRombauts
Copy link
Owner

Yes, it's intentional since I received bug reports when I have only the logs to try to understand what's going on.

Sorry for the inconvenience, the idea would be to add a setting to have this optional.

@ccarvalheiro
Copy link
Contributor Author

Oh, that makes sense. I can help with that. Should we add a checkbox to the source control dialog or hide it away in project settings (in the plugin settings category)?

@SRombauts
Copy link
Owner

Hello, until now I have always put everything on the source control dialog.

Perhaps should we also be able to find some of these settings also in the project settings? I never thought about it but I am pretty sure it would help people find them.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants