Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Common should not reference domain #1093

Open
5 tasks
matt-goldman-ssw opened this issue Oct 16, 2024 · 1 comment
Open
5 tasks

🐛Common should not reference domain #1093

matt-goldman-ssw opened this issue Oct 16, 2024 · 1 comment

Comments

@matt-goldman-ssw
Copy link
Contributor

Cc: @zacharykeeping

Hi Zach

Describe the Bug

<ProjectReference Include="..\Domain\SSW.Rewards.Domain.csproj" />

The Common project has a dependency on Domain - and this means the UI does too. This should not be there and breaks CA principles.

To Reproduce

Steps to reproduce the behavior:

1.N/A

Expected Behavior

UI should not have a dependency on domain

Tasks

  • Investigate who added this (if it was me feel free to publicly shame me)
  • Fix

Acceptance Criteria

More Information

Environment

  • Device: [e.g. iPhone 12]
  • OS: [e.g. iOS]

Screenshots

Thanks!

@zacharykeeping
Copy link
Member

Looks like the change is from here: #937

@matt-goldman-ssw matt-goldman-ssw changed the title 🐛[urgent] Common should not reference domain 🐛Common should not reference domain Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants