-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Common should not reference domain #1093
Comments
Looks like the change is from here: #937 |
matt-goldman-ssw
changed the title
🐛[urgent] Common should not reference domain
🐛Common should not reference domain
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cc: @zacharykeeping
Hi Zach
Describe the Bug
SSW.Rewards.Mobile/src/Common/Shared.csproj
Line 16 in ce2d6f6
The
Common
project has a dependency onDomain
- and this means the UI does too. This should not be there and breaks CA principles.To Reproduce
Steps to reproduce the behavior:
1.N/A
Expected Behavior
UI should not have a dependency on domain
Tasks
Acceptance Criteria
Domain
inCommon
removedMore Information
Environment
Screenshots
Thanks!
The text was updated successfully, but these errors were encountered: