Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©πŸΌβ€πŸ’» Containerise Solution #506

Closed
6 of 9 tasks
Tracked by #505
tkapa opened this issue Dec 13, 2023 · 5 comments Β· Fixed by #574
Closed
6 of 9 tasks
Tracked by #505

πŸ‘©πŸΌβ€πŸ’» Containerise Solution #506

tkapa opened this issue Dec 13, 2023 · 5 comments Β· Fixed by #574
Assignees

Comments

@tkapa
Copy link
Member

tkapa commented Dec 13, 2023

Cc: @GordonBeeming
Hey @matt-goldman,

We briefly discussed containerisation of SSW.Rewards, and I think it would be awesome to get that up and running!

The Pain:

SSW Rewards requires some effort to set up and run properly. It would be a much better F5 Experience if we could simply run docker compose build and docker compose up to run our entire back end and get developing!

Solution:

  • See the existing ./.docs/instructions_compile.md

Set up containers:

Gold plating

  1. Do we still need DevTunnels if we are running API on Docker?
@tkapa tkapa added tech debt and removed tech debt labels Dec 13, 2023
@tkapa tkapa changed the title Containerisation (TODO, Matt G. chat with Gordon, new PBI) πŸ‘©πŸΌβ€πŸ’» Containerise Solution Dec 13, 2023
@GordonBeeming
Copy link
Member

@tkapa

DevTunnels is for the mobile app to connect in I'd imagine?

Is devcontainers an option to simplify this F5 experience?

@tkapa
Copy link
Member Author

tkapa commented Dec 22, 2023

@GordonBeeming

DevTunnels is for the mobile app to connect in I'd imagine?

I believe so - Previously, Ngrok was the suggested solution.

Is devcontainers an option to simplify this F5 experience?

Yes - though not just to help with DevTunnels. There is also the issue of needing to run SSW.IdentityServer + API + Mobile locally in order to test MobileUI changes, it becomes a pain.

There's a lot that could be done to improve the local dev experience for this project.

@GordonBeeming
Copy link
Member

GordonBeeming commented Dec 22, 2023

I think it would be uber cool if the identity server components were containerized using docker and published to an SSW Container feed, Azure Container Registry or the GitHub packages feed would work... then you could pull the latest images from there into your dev container and just fire it up... but I guess that's for a future time πŸ™‚

@matt-goldman
Copy link
Contributor

but I guess that's for a future time

I think that's specifically what's being requested here. If you want to work on the UI for SSW Rewards, whether it's the admin portal or the mobile app, you need a lot of moving parts in the back end. One challenge to be aware of here is using dev tunnels. Currently if you use ngrok or dev tunnels (or any other tunneling protocol), you can specify the API and IDP using their tunnel addresses. The API and IDP can then also reach each other over these tunnels. Fortunately you can set up dev tunnels using the .NET CLI now, so we may be able to incorporate this into the script.

An alternative approach, and one we should probably consider for now, is to simply use the dev or staging instance in Azure for development.

@matt-goldman matt-goldman removed their assignment Jan 3, 2024
@tkapa
Copy link
Member Author

tkapa commented Jan 3, 2024

As per my conversation with @matt-goldman we should use the Azure SQL Edge Docker image for best compatibility on different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants