Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename configuration parameters targetModules and skipModules? #27

Closed
nrainer opened this issue Sep 4, 2018 · 4 comments
Closed

Rename configuration parameters targetModules and skipModules? #27

nrainer opened this issue Sep 4, 2018 · 4 comments
Assignees

Comments

@nrainer
Copy link

nrainer commented Sep 4, 2018

Characteristics

  • Issue Type: maintenance

Description

I just found out that these parameters might be confusing after the last fix.
skipModules excludes tests from a given module and ensures that no code is fetched from the module (since fix #22). However, targetModules was not adjusted by #22 and includes tests from the specified modules without filtering the code. The difference between these two parameters might be unexpected.

Proposal

  • Shall we remove the skipModules parameter and replace it by skipTestsFromModules and skipCodeFromModules?
  • Do we need a migration or something similar for that?
  • Do we need targetModules? Is this often used? If not, can it be removed? Shall it be split similarily otherwise?

Any thoughts on this?

@Cael35
Copy link

Cael35 commented Sep 10, 2018

Originally targetModules and skippedModules were related to test execution, it would probably be better to rename them, and to have also properties to skip or specify classes to be mutated.
It may be useful to have the options to specify either modules to be skipped or processed. Depending of the size of the project, having only targetModules can be painful. :-)
I'll try to fix this in the next release.

@nrainer
Copy link
Author

nrainer commented Sep 11, 2018

Sounds good to me. :)

@Cael35
Copy link

Cael35 commented Sep 21, 2018

I kept targetModules and skippedModules to manage directories where to run PIT, and I added new properties to manage the code to be mutated (https://github.com/STAMP-project/pitmp-maven-plugin#running-pitmp-on-your-project) : targetDependencies / ignoredDependencies
There are include in the next version (1.3.5), which will be released on Monday (waiting for the next release of Descartes)
But if you can't wait to use it, 1.3.5-SNAPSHOT is up to date and is tested with PIT 1.4.2 and Descartes 1.2.4 :-)

@Cael35 Cael35 self-assigned this Sep 21, 2018
@nrainer
Copy link
Author

nrainer commented Sep 21, 2018

Great, thank you!

@nrainer nrainer closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants