Moved calculation methods from GridItem to own util file and using it for dropping item. #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented changes for fixing this issue - #1107
The problem was, that the newly created dropping items were in
ReactGridLayout:onDragOverset to coordinatesx:0, y:0which caused the element jumpings.So I decided to set the correct coordinates right from the beginning. It required the method for calculating the grid coordinates from pixels, which was already done in
GridItem:calcXY. So only this method needed to be moved to a separate file, but I thought, that it could be better to keep all calculation methods still together, that is why I moved all of them to new util file.