Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade to babel 7 #1013

Merged
merged 8 commits into from
Oct 10, 2019
Merged

chore(deps): upgrade to babel 7 #1013

merged 8 commits into from
Oct 10, 2019

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Sep 27, 2019 •
edited
Loading

Upgrade to babel 7. Updated all examples to use ES6 module syntax.

This cleans up a bunch of old syntax, gets us on the latest bugfixes & clears up a lot of the dev dependency tree.

@STRML STRML added this to the 0.17.0 milestone Oct 9, 2019
@github-actions github-actions bot added deps use this label for changes in the project's dependencies infrastructure labels Oct 9, 2019
@github-actions github-actions bot added the documentation use this label for changes in documentation label Oct 9, 2019
@STRML STRML requested review from daynin and n1ghtmare October 9, 2019 16:37
STRML added 2 commits October 9, 2019 12:43
@STRML
fix(test): ensure espower & present and let webpack handle modules
86cffca 
babel-loader will automatically set modules:false when instantiated,
so we shouldn't set it on .babelrc.js, because it will break jest et al.
@STRML
fix(test): add @babel/cli
5aea831
daynin
daynin requested changes Oct 10, 2019
View reviewed changes
test/examples/1-basic.jsx Outdated Show resolved Hide resolved
n1ghtmare
n1ghtmare reviewed Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@n1ghtmare n1ghtmare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry if this is not the place to ask for this, but it would make my life so much easier (it's possible also that I'm not doing something right, than feel free to ignore this). Also this has nothing to do with my review comments.

Is it possible that we add a prettier config with the rules set that are used by the project? My personal prettier settings are different from what the project (apparently) uses, and I'm sure it would be the same case for many contributors and we don't want formatting diffs.

package.json Show resolved Hide resolved
@STRML
Copy link
Collaborator Author

STRML commented Oct 10, 2019

Thanks for pointing out those errors, @daynin @n1ghtmare. Both are fixed and we can merge.

Re: prettier I have no problem with us getting that properly worked out, let's do it in another PR once this merges and have it in for 0.17.0.

@STRML STRML mentioned this pull request Oct 10, 2019
Closed
@STRML STRML merged commit fcb2305 into master Oct 10, 2019
@STRML STRML deleted the babel7 branch October 10, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ghtmare n1ghtmare n1ghtmare left review comments

@daynin daynin daynin requested changes

Assignees
No one assigned
Labels
deps use this label for changes in the project's dependencies documentation use this label for changes in documentation infrastructure
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@STRML @daynin @n1ghtmare