added an ability to use different margins for different breakpoints. #964 #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent breakpoints.
daynin
requested changes
Sep 30, 2019
daynin
requested changes
Sep 30, 2019
- update README; - update default value for margin into RRGL;
daynin
requested changes
Sep 30, 2019
lib/ResponsiveReactGridLayout.jsx
Outdated
| * @param {String} breakpoint Breakpoint: lg, md, sm, xs and etc. | ||
| * @return {Array} | ||
| */ | ||
| getMarginPaddingValue = (param: any, breakpoint: string) => { |
There was a problem hiding this comment.
I think it'll be better to extract this method into a separate function in this file. It doesn't seem like a member of the class and maybe we should rename it: 'getMarginPaddingValue' -> 'getIndentationValue'
daynin
approved these changes
Sep 30, 2019
STRML
reviewed
Sep 30, 2019
README.md
Outdated
| // # of cols. This is a breakpoint -> cols map, e.g. {lg: 12, md: 10, ...} | ||
| cols: ?Object = {lg: 12, md: 10, sm: 6, xs: 4, xxs: 2}, | ||
|
|
||
| // # of margin. This is a breakpoint -> margin map, e.g. {lg: [10, 10], md: [10, 10], ...} or [10 , 10] |
There was a problem hiding this comment.
This comment is a little unclear.
Suggest:
// margin (in pixels). Can be specified either as horizontal and vertical margin, e.g. `[10, 10]` or as a breakpoint -> margin map, e.g. `{lg: [10, 10], md: [10, 10], ...}.
margin: [number, number] | {[breakpoint: $Keys<breakpoints>]: [number, number]}
lib/ResponsiveReactGridLayout.jsx
Outdated
| * @return {Array} | ||
| */ | ||
|
|
||
| function getIndentationValue(param: any, breakpoint: string) { |
|
@STRML i think we should merge it |
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ability to use different margins, containerPaddings for different breakpoints.
Fixes #964