Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GridItem): ensure locally set isDraggable/isResizable overrides globals #1060

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Oct 29, 2019

This also makes static items resizable/draggable if locally set, which is
a nice option but will break backcompat.

Supersedes #1050
Fixes #478

…lobals

This also makes static items resizable/draggable if locally set, which is
a nice option but will break backcompat.
@STRML STRML requested a review from daynin October 29, 2019 23:32
@STRML
Copy link
Collaborator Author

STRML commented Oct 29, 2019

This backcompat break would necessitate a bump to 0.18.0.

@github-actions github-actions bot added core use this label for changes in `lib` directory documentation use this label for changes in documentation labels Oct 29, 2019
@STRML STRML requested a review from n1ghtmare November 20, 2019 15:57
Copy link
Collaborator

@n1ghtmare n1ghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRML STRML merged commit 7c6ef3e into master Nov 20, 2019
@STRML STRML deleted the fix/static-local-draggable-resizable branch November 20, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core use this label for changes in `lib` directory documentation use this label for changes in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - grid item isDraggable does not override global setting
2 participants