Pass event to onDrop callback #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafficmedia
changed the title
grafficmedia
changed the title
|
@n1ghtmare @Jacob-Grafenstein I would like to ask in which version will complete the repair of this feature, I am using version 0.17.1, still can not use onDrop callback |
|
@n1ghtmare any idea of date for the next release ? |
|
I'm also hoping that the "new" layout will be passed as a parameter of OnDrop (the state.layout object inside ReactGridLayout.js). |
|
@sulihuang great question, I would also like to see this feature released. I am not a part of the project, just a good citizen who fixed an issue. @STRML This would greatly increase adoption of the drag and drop feature of RGL. Any idea when we might see a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onDrop callback is unusable in its current state. This PR will allow the user to retrieve the event that is passed to the onDrop callback such that they will be able to access the dataTransfer object to retrieve information about the gridItem they want to add to the layout.
Fixes issue #1058
Thanks for submitting a pull request to RGL!
Please reference an open issue. If one has not been created, please create one along with a failing
example or test case.
Please do not commit built files (
/dist) to pull requests. They are built only at release.