Add shouldComponentUpdate to major components.
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deps
#760 1) Add shouldComponentUpdate for ReactGridLayout 2) Add shouldComponentUpdate for GridItem 3) Fix when items are dragging not from own position, but from zero top left
This improves performance quite a bit in most cases, is implemented safely to avoid breakage on equal arrays and objects. To do so, while avoiding the maintenance burden of keeping a keylist in sync with propTypes, we read propTypes using babel-plugin-preval then construct a function to do the fastest possible comparison. This is *a lot* faster than isEqual while avoiding unnecessary comparison of e.g. `children`.
|
This looks ready to be merged. @STRML are there issues with it? I've tested it and everything seems ok. Need some help with it? |
n1ghtmare
approved these changes
Feb 16, 2020
|
Nope. Just concerned that it could cause the grid to miss updates in
certain conditions. I haven't found them though.
…On Sun, Feb 16, 2020, 2:04 PM Dimitar Dimitrov ***@***.***> wrote:
***@***.**** approved this pull request.
Really cool! This should be much faster. I've tested it locally and I
don't see any issues. Is there a specific area this change could affect?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1123>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJEKPZTWCDA2KHARZ5MYB3RDGE4RANCNFSM4KGIJUFQ>
.
|
|
Hi! thanks for great component. But after adding shouldComponentUpdate shallow comparison, when i'am using ResponsiveReactGridLayout it is is won't rendering at all! (obliviously why) i'am using dynamic count of elements with array inside body, like this ->
thanks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(render): Add shouldComponentUpdate to ReactGridLayout & GridItem.
This improves performance quite a bit in most cases, is implemented safely
to avoid breakage on equal arrays and objects.
To do so, while avoiding the maintenance burden of keeping a keylist
in sync with propTypes, we read propTypes using babel-plugin-preval
then construct a function to do the fastest possible comparison.
This is a lot faster than isEqual while avoiding unnecessary
comparison of e.g.
children.Supersedes #1032 - pinging @zaykaalexander.