Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDragOver firefox issue #1310

Merged
merged 1 commit into from
Nov 30, 2020
Merged

onDragOver firefox issue #1310

merged 1 commit into from
Nov 30, 2020

Conversation

romeo-str
Copy link
Contributor

@romeo-str romeo-str commented Oct 5, 2020

line 588: e.nativeEvent.target.className.indexOf(layoutClassName)
give "TypeError: e.nativeEvent.target.className.indexOf is not a function"

replaced by:
!e.nativeEvent.target.classList.contains(layoutClassName)

line 588: e.nativeEvent.target.className.indexOf(layoutClassName)
give "TypeError: e.nativeEvent.target.className.indexOf is not a function"

replaced by:
!e.nativeEvent.target.classList.contains(layoutClassName)
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days

@github-actions github-actions bot added the stale The label to apply when a pull request or an issue is stale label Nov 4, 2020
@stephsprinkle
Copy link

@STRML Would it be possible to get this fixed merged in? Our project is also affected by this error.

@STRML STRML merged commit 245cd21 into react-grid-layout:master Nov 30, 2020
@jacekpolak
Copy link

@STRML could you please share when this fix could be released to 1.3.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The label to apply when a pull request or an issue is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants