Firefox dragover #1333
Merged
Firefox dragover #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@STRML Could an npm release be created with this fix, please? And thanks for the whole project, I really love your library! |
|
Yep - released as |
Thanks heaps mate! |
|
I'm experiencing something strange. Look at this issue - #1838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is picking up from a separate PR that is stale: #1053
There has been a related issue opened since the original PR: #1324
If you try to drop an item over a placeholder in Firefox, the onDrop function is not invoked.
I found that with the current state of the project, it was only necessary to add preventDefault() to the event when using Firefox to resolve this.