Skip to content

add RTL support by 'transformDirection' prop #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

davidantoon
Copy link

Related issue: #453
Adding support for RTL direction websites

@Roshdy
Copy link

Roshdy commented Feb 7, 2019

Has this been included yet?

@davidantoon
Copy link
Author

davidantoon commented Feb 7, 2019

No, i need to add support for resizing layout with rtl driection.

@Roshdy
Copy link

Roshdy commented Feb 7, 2019

Can i help?

@davidantoon
Copy link
Author

sure

@Roshdy
Copy link

Roshdy commented Feb 7, 2019

Where should we chat?
My first finding is that this package depends on React-Resizable,
which has to be modified based on direction to subtract instead of add delata.X
on this line
or if we shouldn't mess around much, we could add onResize direction handler ?
along with a set of new css for react-resizable-handle class

@davidantoon
Copy link
Author

Whatsapp, Email, Zoom, Skype?
This is my email address: davidmantoon@gmail.com
Send me your phone number via mail with the country prefix to add you to the whatsapp.

@Roshdy
Copy link

Roshdy commented Feb 7, 2019

I have sent to you my number in an email.
I have committed the changes to your repo.
But unfortunately it'll depend on @STRML to accept my pull request on React-Resizable

@github-actions
Copy link

github-actions bot commented Nov 8, 2019

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days

@github-actions github-actions bot added the stale The label to apply when a pull request or an issue is stale label Nov 8, 2019
@adir1661
Copy link

i am looking for this support of rtl too

@sapter
Copy link

sapter commented Oct 21, 2021

I'm also looking for RTL support. @Roshdy have you ever gotten it to work?

@Roshdy
Copy link

Roshdy commented Oct 23, 2021

@sapter I managed to make it work locally. by the time I submitted the PR i had no conflicts, however, i'm ready to solve them if merging is available.
But just a heads-up, this PR depends on another PR in the React-Resizable package.

@sapter
Copy link

sapter commented Oct 23, 2021

@Roshdy yes I noticed that as well (and that one has conflicts as well at this point). And both packages are by the same author.

@STRML any chance you'll get this and this merged once conflicts are resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The label to apply when a pull request or an issue is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants