Size props changed during resizing. it caused a bug. #99
Comments
STRML
added a commit
that referenced
this issue
Oct 24, 2019
* refactor(Resizable): remove draggable state This must have been a vestigal bit of state from before the Resizable/ResizableBox refactor years ago. It is not actually needed and with the React 16.9 refactor to remove CWRP, it became obvious it was actually not useful. Fixes #99 Supersedes #100 Partially fixes #107, #110 * fix(ResizableBox): Fix 16.9 CWRP deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for opening an issue!
Please select the type of issue you're reporting. For questions.
Problem Report
Size props changed during resizing. caused a bug.
I calibrate the box size asynchronously.
If it is executed during resizing,
<Resizable />`s state and props will be mismatched.image : props and state are mismatched
in my opinion, just remove
!this.state.resizingincomponentWillReceivePropsonResizable.js.Is
!this.state.resizingcondition really necessary? Why need it? Can not we remove it?I tried to remove it. It worked very well and did not cause a bug.
I posted a pull request #100. Please review it.
System Info
Node Version: v8.11.3
Browser: chrome
OS: Mac os Mojave
Reproduction
If this is a bug report, please provide a reproduction of the issue by going to
https://codesandbox.io/s/9229wz40yo?fontsize=14.
Paste a link here to your working reproduction.
The text was updated successfully, but these errors were encountered: