Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties panel instantly closes #1

Open
itMax86 opened this issue Jan 26, 2019 · 39 comments
Open

Properties panel instantly closes #1

itMax86 opened this issue Jan 26, 2019 · 39 comments
Labels
bug Either a confirmed bug, or one in the process of sorting out.

Comments

@itMax86
Copy link

itMax86 commented Jan 26, 2019

I try this on win10 build 18323.1000 in both admin cmd and not, but when i launch the command proprieties pannel open for a second and then close itself

@STaRDoGG STaRDoGG changed the title Proprieties pannel istant closed Properties panel instantly closes Jan 28, 2019
@STaRDoGG
Copy link
Owner

STaRDoGG commented Jan 28, 2019

I'm not clear on the issue; when you run gdprops.exe with no parameters it should just show an info window (the "about" screen").

How exactly are you opening it? By typing "gdprops" in a command Window? With or without parameters? Are you on x64 or x86?

@Drakonas
Copy link

Drakonas commented Jul 27, 2019

I also have this issue. I am on Microsoft Windows 10 [Version 10.0.17763.615]. It seems to be random. I have %DESKTOPDIR% set to C:\Users\myuser\Desktop.

I am running the below command within a Batch script:

GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"

This should resolve to:

GDProps.exe "C:\Users\myuser\Desktop\My Shortcut.lnk"

50% of the time the Properties window instantly closes after opening, 50% of the time it works and stays open.

Please advise.

@Drakonas
Copy link

Update: This may have been caused from failure to restart after a very long time, 17 days to be exact. Windows 10 has a habit of going into a special "sleep mode" even though I shut down the machine and have turned off hibernation. Really irritating as you have to choose restart to actually give the system a breather.

Regards,

@STaRDoGG
Copy link
Owner

@Drakonas lemme know if you still think that was what the problem was, after a while.

@Drakonas
Copy link

Drakonas commented Aug 19, 2019

@STaRDoGG It seems to still be 50/50 opening and not opening, actually, even though the machine has had updates. I've made sure it still happens and it is consistent.

@kapi2454
Copy link

It clouse after open :(

@YouveGotMeowxy
Copy link

It clouse after open :(

How are you calling it? From a script, like @Drakonas was?

@YouveGotMeowxy
Copy link

I am running the below command within a Batch script:

GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"

Just curious, when it auto closes from the call within a batch file, is it happening when you double-click the .bat, but not auto-close if typing the .bat's file name into a command-line?

@kapi2454
Copy link

kapi2454 commented Apr 28, 2020

I am running the below command within a Batch script:
GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"

Just curious, when it auto closes from the call within a batch file, is it happening when you double-click the .bat, but not auto-close if typing the .bat's file name into a command-line?

I try that but doesn't work.

  • I make a .bat: GDProps.exe aaaa.pdf then I call with a bat, (not work) call manually from command line (doesn't work), double click on it (doesn't work) .

  • make a .lnk to the .bat that contains GDProps.exe aaaa.pdf call with another bat (doesn't work) call manually from cmd (doesn't work) , double click on it (doesn't work) .

:(

@YouveGotMeowxy
Copy link

YouveGotMeowxy commented Apr 28, 2020

I am running the below command within a Batch script:
GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"

Just curious, when it auto closes from the call within a batch file, is it happening when you double-click the .bat, but not auto-close if typing the .bat's file name into a command-line?

I try that but does´t work.

I make a bat "GDProps.exe aaaa.pdf" then I call with a bat, (not work) call manually from command line (not work), double click on it (not work) .
make a lnk to the bat that contain "GDProps.exe aaaa.pdf", call with another bat (not work) call manually from cmd(not work) , double click on it (not work) .
:(

@kapi2454

Does gdprops.exe run (show it's about screen) when you just double-click the .exe without giving it a path to another file?

@robbely
Copy link

robbely commented Jul 13, 2021

Did anyone work out a fix for this? I'm getting the same issue (instantly closes). If you open another properties panel manually first it will stay open - which kind of defeats the object but might shed some light on why it is failing.

@STaRDoGG
Copy link
Owner

STaRDoGG commented Jul 13, 2021

@robbely I haven't worked on it at all. I need a exact set of tested steps to try and replicate it first.

Also need the OS it's being attempted on.

Lastly, even with that info at the moment, I can't really get to it because my dev machine is down. I have all my dev stuff in a vmware image, and whenever I try to fire it up now, all I get is a black screen. I haven't gotten that sorted out yet, so if you or anyone else reading this knows the fix, please lemme know. =)

P.S. if anyone else sorts it out, pull requests are welcome.

@robbely
Copy link

robbely commented Jul 13, 2021

I run the program from a batch file, however I can reproduce the issue by opening a command prompt and typing:

"C:\Users\User\Desktop\GDProps.exe" C:\sources

Having gdprops.exe moved somewhere else, or using a different folder for the properties panel, or adding \ at the end all leads to the same result of the properties panel of "c:\sources" opening and closing instantly. Replacing C:\sources with other folders on my system also leads to opening and instant closing.

If I first manually open up the properties panel of a random folder (in the script I am using system settings as this can be opened without gdprops) and then try the above, the c:\sources property panel opens and stays open.

I am using Windows 10 x64 21H1 but have had this issue since v1903.

EDIT: I don't know enough about VM's re your black screen problem but it might not be vm-related but a problem with the installed system so you could look for fixes as though it wasn't a vm (although I imagine you have already tried that).

@STaRDoGG
Copy link
Owner

@robbely does the same thing happen with files, too? Or is it only happening with folders?

@robbely
Copy link

robbely commented Jul 14, 2021

I just tried some files and again it just opens and closes. Also again, it remains open if I have another properties panel manually opened, so it looks like both files and folders.

@sjlei
Copy link

sjlei commented Jul 19, 2021

@STaRDoGG I also encountered this problem...
Please see the gif picture.
gif

windows10 21H1 (19043.1110)

@STaRDoGG
Copy link
Owner

@sjlei thanks for the report. I suspect it may have to do with the code that checks for the window class/title, but as i mentioned in an earlier post my development machine is out of commission at the moment, so i can't attack this bug until i get that sorted out first, and so far have had no luck.

As soon as i get it back up and running i will work on this.

In the meantime, it might help me if users with this problem let me know exactly which program(s) this is happening to, for example, notepad.exe, blah.exe, etc.

@Drakonas
Copy link

Drakonas commented Dec 19, 2021

In the meantime, it might help me if users with this problem let me know exactly which program(s) this is happening to, for example, notepad.exe, blah.exe, etc.

What do you mean? I'm running this from a batch script to run it on a shortcut file (.lnk). There is no other software involved.

It also happens from the command line, not just double-clicking on the script.

@STaRDoGG
Copy link
Owner

STaRDoGG commented Dec 19, 2021

What do you mean? I'm running this from a batch script to run it on a shortcut file (.lnk). There is no other software involved.

It also happens from the command line, not just double-clicking on the script.

I'm going to need more info, because I can't reproduce it over here:

capture

I also tested entering the content of my .bat directly into the cline and no problem. Can you post the exact code in your .bat file? Also, anything else you may think might help.

@STaRDoGG
Copy link
Owner

@STaRDoGG I also encountered this problem... Please see the gif picture. gif

windows10 21H1 (19043.1110)

I can't reproduce it here with a .txt either:

capture

Looks like an elusive bug.

@STaRDoGG
Copy link
Owner

I also have this issue. I am on Microsoft Windows 10 [Version 10.0.17763.615]. It seems to be random. I have %DESKTOPDIR% set to C:\Users\myuser\Desktop. I am running the below command within a Batch script:

GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"

This should resolve to:

GDProps.exe "C:\Users\myuser\Desktop\My Shortcut.lnk"

50% of the time the Properties window instantly closes after opening, 50% of the time it works and stays open.

Ok, working backwards through the comments I saw your earlier one using an environment var instead, and it's happening here as well:

"G:\FileMenuTools\App\FileMenu Tools\My Custom Additions\Misc\GeekDrop\Props\GDProps.exe" "%DESKTOPDIR%\My Shortcut.lnk"

I'll take a look.

@Drakonas
Copy link

I also have this issue. I am on Microsoft Windows 10 [Version 10.0.17763.615]. It seems to be random. I have %DESKTOPDIR% set to C:\Users\myuser\Desktop. I am running the below command within a Batch script:
GDProps.exe "%DESKTOPDIR%\My Shortcut.lnk"
This should resolve to:
GDProps.exe "C:\Users\myuser\Desktop\My Shortcut.lnk"
50% of the time the Properties window instantly closes after opening, 50% of the time it works and stays open.

Ok, working backwards through the comments I saw your earlier one using an environment var instead, and it's happening here as well:

"G:\FileMenuTools\App\FileMenu Tools\My Custom Additions\Misc\GeekDrop\Props\GDProps.exe" "%DESKTOPDIR%\My Shortcut.lnk"

I'll take a look.

As you can see from the GIF's above though, they aren't using environment var's and it still occurs.

@STaRDoGG
Copy link
Owner

Just uploaded a test version, let me know how it goes.

https://github.com/STaRDoGG/GeekDrop-Props/releases/tag/v1.2.1

@robbely
Copy link

robbely commented Dec 21, 2021

Just uploaded a test version, let me know how it goes.

Many thanks for the update, unfortunately this one still instantly closes for me.
Again it will remain open if I have any properties panel already open elsewhere.

@STaRDoGG
Copy link
Owner

@robbely notta problem. I didn't actually change anything that i thought might be related to that issue, just the one addressing environment variables in paths. 😜

Thought I'd just see if it magically solved itself in the process, lol.

I'm not done with it yet, keep an eye out for another update soon.

@robbely
Copy link

robbely commented Aug 8, 2022

Have you had any success with this so far?

@STaRDoGG
Copy link
Owner

Have you had any success with this so far?

I was working on it (and forget now off the top of my head how far I got on it) and got sidetracked with other issues. atm my main puter is jacked up and I'm working off of a usb stick, so I don't have access to my dev environment, but it's still on my list of todo's. Hopefully eventually I'll get it done. :p

@robbely
Copy link

robbely commented Aug 16, 2022

Many thanks for the update.

my main puter is jacked up and I'm working off of a usb stick

That doesn't sound good! I hope it's not causing you too much stress.

@robbely
Copy link

robbely commented Apr 7, 2023

I purchased a new PC to replace my aging one and the issue isn't present in the new one (at least for now) - so it is likely some software or a windows setting on the old PC causing this.

Whatever is causing it, it looks like one of those annoying very subtle issues.

@D0BR0MYSL
Copy link

D0BR0MYSL commented Oct 22, 2023

Hi, @STaRDoGG . Thanks for the app. I found the root of mentioned issue:
frmMain.vb: row 72
Function(FindProcess) FindProcess.Contains("#32770") **AndAlso FindProcess.Contains(" Properties")**)
The problem is quite simple - the verb of the Properties tab is hardcoded to be in English language only. I changed " Properties" verb in according with my current language Windows UI (not English) and problem was solved but still for ONE language only.
Unfortunately, I am not familiar enough with VB and .Net, so I am asking for help to add multilanguage support. I assume, we need a way to fill the lFound string list without using AndAlso FindProcess.Contains(" Properties"), so that the application will correctly wait for external properties window got closed.

@robbely
Copy link

robbely commented Oct 23, 2023

The problem is quite simple - the verb of the Properties tab is hardcoded to be in English language only.

Unfortunately I can't reproduce the issue on my new PC, but both it and my old PC used the same English language Windows, yet I still had the issue on the old PC

@D0BR0MYSL
Copy link

D0BR0MYSL commented Oct 23, 2023

The problem is quite simple - the verb of the Properties tab is hardcoded to be in English language only.

Unfortunately I can't reproduce the issue on my new PC, but both it and my old PC used the same English language Windows, yet I still had the issue on the old PC

I will clarify another time, just in case: this issue appearing ONLY on NON-English Windows builds. All languages are affected and the program will close itself immediately, except English Windows build.

@robbely
Copy link

robbely commented Oct 23, 2023

I will clarify another time, just in case: this issue appearing ONLY on NON-English Windows builds. All languages are affected and the program will close itself immediately, except English Windows build.

If you look at my several previous posts in this thread, you can see I previously had the same issue. This was on an English Windows build, so it is not only on non-English builds.

Others in this thread have also had this issue, though it is unclear which language their builds are.

@D0BR0MYSL
Copy link

D0BR0MYSL commented Oct 23, 2023

If you look at my several previous posts in this thread, you can see I previously had the same issue. This was on an English Windows build, so it is not only on non-English builds.

Others in this thread have also had this issue, though it is unclear which language their builds are.

Interesting. Thanks for pointing on this. Well, I am currently have Windows 11 Pro Russian build 22621.2428. Сhanging the werb " Properties" on "Свойства" at row 72 of main module and recompiling helped me. Thus I clearly see hardcoded relation to language. I think on English Windows builds there may be two variants of this verb - " Properties" (with space before) and "Properties" (without space).

@robbely
Copy link

robbely commented Oct 24, 2023

there may be two variants of this verb - " Properties" (with space before) and "Properties" (without space).

This is definitely possible and may have changed in recent English Windows builds - which would explain why I can't reproduce the issue on my new PC.

I assume, we need a way to fill the lFound string list without using AndAlso FindProcess.Contains(" Properties"), so that the application will correctly wait for external properties window got closed.

IIRC the string used comes from localised .mui files - so it might be possible to get the correct string programmatically instead of using a hard-coded one.

@STaRDoGG
Copy link
Owner

BTW, one thing to confirm when seeing the panel instantly disappear is to make sure the path(s) you pass to the command line have no spaces in them (wrap in double quotes).

@STaRDoGG STaRDoGG added the bug Either a confirmed bug, or one in the process of sorting out. label Nov 9, 2023
@ph0enixph0enix
Copy link

@STaRDoGG:

I'm on a german Win 10 machine and need this tool for one of my projects. Also for me the tool closes itself right after displaying the prop dialog no matter how I call it (cli / batch / ...). As I'm not a VB.NET coder but a Java programmer. I would try the fix suggested by @robbely and recompile your neat little program myself, but I guess I'm lacking these skills in languages that are not Java.

Is it possible to do a quick and dirty replace of this in frmMain.vb:

Function(FindProcess) FindProcess.Contains("#32770") AndAlso FindProcess.Contains(" Properties"))

replace by this:
Function(FindProcess) FindProcess.Contains("#32770") AndAlso FindProcess.Contains(" Eigenschaften"))

I would be very thankful!

I've found no other programs that could work on Windows 10.

@STaRDoGG
Copy link
Owner

@ph0enixph0enix

Heyas bud,

Ya happened to catch me with a free minute. =)

Here's a compiled version with literally your only requested change: clicky

Eventually I wouldn't mind actually adding localization to the app, but, so many projects to do .... lol

@ph0enixph0enix
Copy link

Thanks @STaRDoGG !

That was very quick. And it works flawlessly.

You're a lifesaver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Either a confirmed bug, or one in the process of sorting out.
Projects
None yet
Development

No branches or pull requests

9 participants