Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/Improve the http_client proxy settings behaviour #954

Open
frispete opened this issue Jan 3, 2023 · 0 comments
Open

Clarify/Improve the http_client proxy settings behaviour #954

frispete opened this issue Jan 3, 2023 · 0 comments
Labels
On hold Issue being evaluated

Comments

@frispete
Copy link

frispete commented Jan 3, 2023

Hi,

in a customer setup, we experienced a somewhat unexpected behaviour:

That site policy required using a (transparent) proxy. We noticed, that changing the system proxy using yast proxy didn't work as expected (no effect). After a while, we noticed a deviating proxy setting in /etc/rmt.conf, and @digitaltom commented, that rmt ignores the system proxy setting altogether.

After thinking a bit more about this issue, I would like to recommend this change (from higher to lower priority):

  • If a proxy setting is found in /etc/rmt.conf, use it, but also define a way to forcefully disable the proxy setting here (e.g.: http_client.proxy: None)
  • If a system proxy setting is defined, use that

Print a message on setup, which proxy setting is in use (if there is one..).
Add a note to the documentation/man page about this behaviour (http_client.proxy vs. http_proxy environment).
While at it, the man page seems to be missing documentation of some possible settings in the http_client section.

If the proxy logic is implemented as such, we cover all kinds of scenarios, including some esoteric ones.
Specifically allow the system proxy to differ from the rmt proxy, while we still adhere to the principle of least astonishment (POLA).

@ngetahun ngetahun added the On hold Issue being evaluated label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold Issue being evaluated
Projects
None yet
Development

No branches or pull requests

2 participants