Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions when constructing lexicon #18

Open
Alan5279 opened this issue Feb 24, 2023 · 0 comments
Open

Questions when constructing lexicon #18

Alan5279 opened this issue Feb 24, 2023 · 0 comments

Comments

@Alan5279
Copy link

When constructing the n-gram lexicon for memory, did you use test dataset? I notice in run.sh, in --eval_data_path the value is the test dataset. But from the code, I assume constructing the lexicon uses only train and eval data, and test set is used for --do_test option.
Moreover, if the test set is used to construct lexicon, some of the words and their statistical features are known to the model.
It doesn't feel right for experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant