Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotwords not respected after PR #856 #1076

Open
carolinaxxxxx opened this issue Oct 22, 2024 · 5 comments
Open

Hotwords not respected after PR #856 #1076

carolinaxxxxx opened this issue Oct 22, 2024 · 5 comments

Comments

@carolinaxxxxx
Copy link

carolinaxxxxx commented Oct 22, 2024

the test video is https://www.youtube.com/watch?v=Ybu6qTbEsew

if no hotwords

segments, info = model.transcribe(input_file, beam_size=5, language="en", vad_filter=False, vad_parameters = dict(min_silence_duration_ms=1000))

the result is:

“[261.76s -> 263.12s] The first thing you need to do is,
[263.12s -> 265.36s] of course, to copy the web address
[265.36s -> 266.12s] up here.
[266.12s -> 267.84s] Then you go into your Conf UI
[267.84s -> 270.04s] folder, again in the Conf UI
[270.04s -> 272.08s] folder, in there in the custom
[272.08s -> 274.08s] nodes folder and then up here
[274.08s -> 276.28s] in the address bar type CMD,
[276.28s -> 277.40s] hit enter.
[277.40s -> 279.40s] This opens up your command
[279.40s -> 281.24s] window. In here you type
[281.24s -> 283.36s] git clone and then
[283.36s -> 285.32s] put the web address and hit
[285.32s -> 287.36s] enter to clone the git
[287.36s -> 289.68s] project into your custom
[289.68s -> 290.56s] nodes folder.
[290.56s -> 291.60s] After you've done this, you're going
[291.60s -> 293.32s] to find in here the Conf UI”

if add hotwords

segments, info = model.transcribe(input_file, hotwords="the video is about comfyUI", beam_size=5, language="en", vad_filter=False, vad_parameters = dict(min_silence_duration_ms=1000)) 

the result is same:

"
“[261.76s -> 263.12s] The first thing you need to do is,
[263.12s -> 265.36s] of course, to copy the web address
[265.36s -> 266.12s] up here.
[266.12s -> 267.84s] Then you go into your Conf UI
[267.84s -> 270.04s] folder, again in the Conf UI
[270.04s -> 272.08s] folder, in there in the custom
[272.08s -> 274.08s] nodes folder and then up here
[274.08s -> 276.28s] in the address bar type CMD,
[276.28s -> 277.40s] hit enter.
[277.40s -> 279.40s] This opens up your command
[279.40s -> 281.24s] window. In here you type
[281.24s -> 283.36s] git clone and then
[283.36s -> 285.32s] put the web address and hit
[285.32s -> 287.36s] enter to clone the git
[287.36s -> 289.68s] project into your custom
[289.68s -> 290.56s] nodes folder.
[290.56s -> 291.60s] After you've done this, you're going
[291.60s -> 293.32s] to find in here the Conf UI”
@carolinaxxxxx
Copy link
Author

@MahmoudAshraf97 will you find time to take a look? Thx.

@MahmoudAshraf97
Copy link
Collaborator

I will, can you share the output before # 856?

@carolinaxxxxx
Copy link
Author

carolinaxxxxx commented Oct 23, 2024

segments, info = model.transcribe(input_file, hotwords="the video is about comfyUI", beam_size=5, language="en", vad_filter=False, vad_parameters = dict(min_silence_duration_ms=1000))
[261.76s -> 263.12s] The first thing you need to do is,
[263.12s -> 264.84s] of course, to copy the web
[264.84s -> 266.68s] address up here, then you go
[266.68s -> 268.48s] into your comfyUI folder,
[268.48s -> 270.80s] again in the comfyUI folder,
[270.80s -> 272.48s] in there in the custom nodes
[272.48s -> 274.28s] folder, and then up here in the
[274.28s -> 276.28s] address bar type cmd,
[276.28s -> 277.40s] hit enter.
[277.40s -> 279.40s] This opens up your command
[279.40s -> 281.20s] window. In here you type
[281.20s -> 283.08s] git clone and
[283.08s -> 285.00s] then put the web address and
[285.00s -> 286.92s] hit enter to clone
[286.92s -> 288.88s] the git project into
[288.88s -> 290.56s] your custom nodes folder.
[290.56s -> 291.48s] After you've done this, you're
[291.48s -> 293.32s] going to find in here the comfyUI

I tested on different materials. It seems like the hotwords option is not respected.

@carolinaxxxxx
Copy link
Author

@MahmoudAshraf97 I forgot to add - the hotwords option is not respected in standard and batching interference.

@MahmoudAshraf97
Copy link
Collaborator

I just tested the video you shared and hotwords worked as expected on several models, although smaller models were less affected, but still affected nonetheless. As for batched transcription, I'm working on adding hotwords support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants