Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some Sysiphus discs cause BoS to hang #334

Open
HeroponRikiBestest opened this issue Nov 2, 2024 · 2 comments
Open

[Bug] Some Sysiphus discs cause BoS to hang #334

HeroponRikiBestest opened this issue Nov 2, 2024 · 2 comments
Assignees

Comments

@HeroponRikiBestest
Copy link
Contributor

Some Sysiphus discs cause BoS to hang due to ring protection resulting in 0x55 that's interpreted as a giant string of 'U', causing pex.overlays to hang forever.

Examples: http://redump.org/disc/39126/ , http://redump.org/disc/100528/
Files:
Ironstorm.ocd.zip
Dame_xxl.cab.zip

@HeroponRikiBestest HeroponRikiBestest changed the title Some Sysiphus siscs cause BoS to hang Some Sysiphus discs cause BoS to hang Nov 2, 2024
@mnadareski
Copy link
Collaborator

Implementation notes:

  • Will need to be updated in Serialization
  • A reasonable cap value for repeated characters needs to be established before it's thrown out (64)

@mnadareski mnadareski self-assigned this Nov 2, 2024
@mnadareski mnadareski changed the title Some Sysiphus discs cause BoS to hang [Bug] Some Sysiphus discs cause BoS to hang Nov 2, 2024
@mnadareski
Copy link
Collaborator

Any string of a single character 64 times will now be discarded in Serialization: SabreTools/SabreTools.Serialization@700b035

This has not been updated in BOS yet, so this item will remain open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants