-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I hope it can support more program languages #2
Comments
python is also be ok |
Thanks for your feedback. Diversity is the primary goal of this project, I hope it can suitable for more programmer no matter what program languages they are using. However, it needs a lot of works to do and take a lot of time. The built-in voices of the extension were came from a friend of mine, two of us certainly can not handle all of these requests in the future. So, I'm hoping the community can contribute more voice packages. And speaking of diversity, it's not only mean different program languages, but also mean different gender, country, etc. Therefore, almost everyone can contribute, I'll be happy to accept such a PR. In general, I think the next move of this project may be like this:
感谢您的反馈意见。 多元化是该项目的主要目标,我希望无论使用哪种程序语言,它都能适合更多程序员。但是,这需要做很多工作,并且要花费很多时间。目前扩展程序的内置声音来自我的一个朋友,只有我们两个人肯定无法处理所有的这些请求。 因此,我希望社区能够贡献更多的语音包。并且,谈到多元化,这不仅意味着不同的程序语言,还意味着不同的性别,国家等。因此,几乎每个人都可以做出贡献,我很高兴接受这样的PR。 总的来说,我认为这个项目的下一步可能是这样的:
|
Thx
Thx for your reply, I hope your project more and more NB(in Chinese) in the future. |
@SaekiRaku Could you provide some guides on how to support other language if you are too busy to deal with all the requests. Though I am not a JS expert, I am willing to hack into this repo. |
@fengyuentau Thanks for your attention, here is a simple guide on customizing voice packages: https://saekiraku.github.io/vscode-rainbow-fart/#/zh/voice-packages.md If you have any question or improvement about this document, I'm glad to have your feedback. P.S. The English version of this document was not translated, I'll be happy to accept PR. Thanks again. |
@SaekiRaku Sorry I did not make myself understood. To clarify, I want it to support more program language since I am not a JS programmer. But the page you provide also works, I will try modify it to fit my case. Thanks. |
IIRC, in the current implementation, voice is trigged based on the keyword that is being typed. It would be great if the keyword list can be provided separately per the programming language. I guess that's what the issue is asking for. |
Sorry, I'm still confused. In the current implementation, if you want to make the voice support other programming languages, you can simply add more keywords to it. Like this: // manifest.json - contributes
{
// JavaScript, Golang
"keywords": ["function", "func"],
"voices": [ "function_01.mp3" ]
} Are you suggesting to make the json file be like this? // manifest.javascript.json
{
// JavaScript
"keywords": ["function"],
"voices": [ "function_01.mp3" ]
}
// manifest.golang.json
{
"keywords": ["func"],
"voices": [ "function_01.mp3" ]
} |
@SaekiRaku I guess that's the key point of this issue. I tried to edit |
@SaekiRaku Thanks for your reply! Yeah, that's what we're hoping for. For one, using a separate keyword list could greatly ease the maintenance. Moreover, that might help resolve ambiguities between different programming languages. For example, the fat arrow (=>) is used to define a lambda in C# and ES6 while in Rust it's used for the pattern matching. Of course, using multiple keyword lists could bring in some duplications. A compromise might be providing a global keyword list plus a language-specific one. What do you think? |
The I recommend you to copy the built-in voice package and change the directory name and the |
@SaekiRaku I followed you suggestion, but it seems that the |
I've tried to use the extension with VSCode Remote on a CentOS server, it works for me. Here is my step:
DO NOT EDIT If you are using windows server, I'm not sure about the path. You can clone this project, and run VSCode command: |
I've conceived some methods to achieve the request, too. for example:
But I think there still has a problem. See, I didn't know the meaning of fat arrow in Rust, and maybe there has another language that also has a different meaning for the fat arrow and we don't know. It will be an annoying job to keep maintain the language-specific keywords list or include/exclude list, and it will keep users waiting for the changing. So I think maybe the best way is to provide a function in the web UI to let users disable specific keywords/voices. |
@SaekiRaku True, that's indeed a problem. I don't have much knowledge about how the voice package is structured, though. I'm wondering if it's possible to bundle the configuration file with the voice resources and make such a voice package the smallest distribution unit (as a separate extension). Then maintaining the keyword list becomes the job of the voice package maintainer. Besides, the user is able to define custom keywords on top of the pre-defined keywords to extend existing voice packages. |
@SaekiRaku 嗨,用了自己开发的emacs-rainbow-fart一段时间了,有用户报告说缺少class语音 https://github.com/stardiviner/emacs-rainbow-fart/issues/10 ,不知道作者朋友能不能添加下。让默认语音包更加完善点。非常感谢 😄 |
I hope it can support more program languages, such as golang, C++. I always write program with golang. I need it makes me BOKI!!
The text was updated successfully, but these errors were encountered: