Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Refactoring in preparation for @Pure annotations #9

Closed
4 tasks done
lukarade opened this issue Oct 25, 2022 · 0 comments
Closed
4 tasks done

Refactoring in preparation for @Pure annotations #9

lukarade opened this issue Oct 25, 2022 · 0 comments
Assignees
Labels
cleanup 🧹 Refactorings and other tasks that improve the code purity Inferring the purity of functions

Comments

@lukarade
Copy link
Contributor

lukarade commented Oct 25, 2022

Is your feature request related to a problem?

Right now, the visit_ast method handles both, traversing the ast-tree and handling its knots. This is inefficient and confusing in some parts.

Desired solution

The method visit_ast should be reworked: traversing and handling the ast-tree should be separated.
Therefor compare: https://github.com/lars-reimann/api-editor/blob/main/package-parser/package_parser/utils/_ASTWalker.py

  • mark all relevant function (those who do not just handle traversing)
  • examine all build in functions
  • check all Astroid knots for impurity
  • TBC.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@lukarade lukarade added the enhancement 💡 New feature or request label Oct 25, 2022
@lukarade lukarade self-assigned this Oct 26, 2022
@lars-reimann lars-reimann transferred this issue from Safe-DS/API-Editor Mar 19, 2023
@lars-reimann lars-reimann added cleanup 🧹 Refactorings and other tasks that improve the code purity Inferring the purity of functions and removed enhancement 💡 New feature or request labels Mar 19, 2023
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Analysis Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup 🧹 Refactorings and other tasks that improve the code purity Inferring the purity of functions
Projects
Archived in project
Development

No branches or pull requests

2 participants