Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re-)add schemata checks as soon as column type recognition is implemented #344

Closed
patrikguempel opened this issue Jun 2, 2023 · 2 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@patrikguempel
Copy link
Contributor

With the upcoming merge of #123, two schemata checks are currently not implemented (anymore) in test_add_column and test_add_columns. The respective checks are commented out. This is, because at the time being, 'schema' does not track column types of empty columns correctly.
After this is fixed by #322, the above mentioned checks should simply be commented back in.

@Marsmaennchen221
Copy link
Contributor

Blocked by #322

@Marsmaennchen221 Marsmaennchen221 moved this from Backlog to 🧱 Blocked in Library Jun 2, 2023
@lars-reimann lars-reimann self-assigned this May 7, 2024
@lars-reimann lars-reimann added the wontfix This will not be worked on label Jan 9, 2025
@lars-reimann
Copy link
Member

Closing this, since we don't compute schemas ourselves anymore.

@lars-reimann lars-reimann closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
@github-project-automation github-project-automation bot moved this from 🧱 Blocked to ✔️ Done in Library Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Status: ✔️ Done
Development

No branches or pull requests

3 participants