Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Try removing @nxrocks/nx-spring-boot #2584

Closed
1 task done
Tracked by #2581
tschaffter opened this issue Mar 21, 2024 · 3 comments · Fixed by #2585
Closed
1 task done
Tracked by #2581

[Story] Try removing @nxrocks/nx-spring-boot #2584

tschaffter opened this issue Mar 21, 2024 · 3 comments · Fixed by #2585
Assignees
Labels
java monorepo Monorepo management

Comments

@tschaffter
Copy link
Member

What product(s) is this story for?

OpenChallenges

As a user, I want

No response

Description

I have trouble upgrading @nxrocks/nx-spring-boot, which is a requirement if we want to use the latest version of Nx. See #2583 for additional info on the issue encountered.

I gave a quick try to running directly gradlew commands instead of using the wrapper provided by @nxrocks/nx-spring-boot and all the tasks seem to work fine.

The goal of this ticket is to replace @nxrocks/nx-spring-boot tasks by nx:run-commands tasks that run gradlew.

Acceptance criteria

No response

Tasks

No response

Anything else?

No response

Have you linked this story to a GitHub Project?

  • I have linked this story to a GitHub Project and set its metadata.
@tschaffter tschaffter added monorepo Monorepo management java labels Mar 21, 2024
@tschaffter tschaffter self-assigned this Mar 21, 2024
@tschaffter
Copy link
Member Author

tschaffter commented Mar 21, 2024

Update build

Replace:

    "build": {
      "executor": "@nxrocks/nx-spring-boot:build",
      "options": {
        "root": "apps/openchallenges/api-gateway"
      },
      "outputs": ["{projectRoot}"],
      "dependsOn": ["^install"]
    },

by:

    "build": {
      "executor": "nx:run-commands",
      "outputs": ["{projectRoot}/build"],
      "options": {
        "command": "./gradlew build",
        "cwd": "{projectRoot}"
      },
      "dependsOn": ["^install"]
    },

@tschaffter
Copy link
Member Author

tschaffter commented Mar 21, 2024

Update test

Replace:

    "test": {
      "executor": "@nxrocks/nx-spring-boot:test",
      "options": {
        "root": "apps/openchallenges/api-gateway"
      }
    },

by

    "test": {
      "executor": "nx:run-commands",
      "outputs": ["{projectRoot}/build"],
      "options": {
        "command": "./gradlew test",
        "cwd": "{projectRoot}"
      },
     "dependsOn": ["^install"]
    },

@tschaffter
Copy link
Member Author

There is an issue with openchallenges-edam-etl:

$ docker logs -f openchallenges-edam-etl
/docker-entrypoint.sh: line 6: exec: gosu: not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java monorepo Monorepo management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant