Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-validation columns contain confusing instructions when valid values don't exist #512

Closed
allaway opened this issue Aug 26, 2021 · 0 comments · Fixed by #510 or #509
Closed

list-validation columns contain confusing instructions when valid values don't exist #512

allaway opened this issue Aug 26, 2021 · 0 comments · Fixed by #510 or #509
Labels
bug Something isn't working

Comments

@allaway
Copy link
Contributor

allaway commented Aug 26, 2021

Describe the bug
Adding list as a validation rule triggers this instruction: From 'Selection options' menu above, go to 'Select multiple values', check all items that apply, and click 'Save selected values'

For columns with Valid Values, this makes sense. However, for columns without defined valid values, this is confusing, because the "Select multiple values" prompt will not include any options.

To Reproduce
Steps to reproduce the behavior:

  1. Create an attribute with no valid values but with list validation, e.g. synonyms in this schema: https://docs.google.com/spreadsheets/d/15fwIhZw7YfhPkzOfQhj6zU_5-_7ywS05-L8qOjMIVdM/edit#gid=149825058
  2. Generate json-ld
  3. Generate manifest that includes attribute without valid values but with list, eg. https://docs.google.com/spreadsheets/d/1opQbHQzl5VWRb5H_FdCaQ1Qr0lrXc3pfut1mu3ULwqw/edit#gid=0
  4. See prepopulated instructions for list validation column.

Expected behavior
I think in this case (list validation but no Valid Values listed), the instructions should instead provide information on how to format a list-column correctly for schematic to correctly interpret the multi-value list.

@allaway allaway added the bug Something isn't working label Aug 26, 2021
@allaway allaway linked a pull request Aug 26, 2021 that will close this issue
@ychae ychae removed a link to a pull request Sep 1, 2021
This was linked to pull requests Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant