Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider updating MGI id to identifiers.org resolver to futureproof this #958

Open
allaway opened this issue May 24, 2024 · 0 comments
Open

Comments

@allaway
Copy link
Contributor

allaway commented May 24, 2024

onMatch: value => `https://www.informatics.jax.org/allele/${value}`,

It turns out that while our use case is for the allelle/ path, MGI ids can resolve to lots of different paths like this: https://www.informatics.jax.org/marker/MGI:97490

We should consider changing how this resolves to avoid breaking in the future - e.g. it's possible someone could add an MGI id that does not reference an allele, like MGI:97490, and Synapse would link to the wrong location, e.g. www.informatics.jax.org/allele/MGI:97490

There are a couple of options that would fix this:
Use identifiers.org/MGI:{id}
Use http://www.informatics.jax.org/accession/MGI:{id}

@allaway allaway changed the title consider updating this to identifiers.org resolver to futureproof this consider updating MGI id to identifiers.org resolver to futureproof this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant