You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should consider changing how this resolves to avoid breaking in the future - e.g. it's possible someone could add an MGI id that does not reference an allele, like MGI:97490, and Synapse would link to the wrong location, e.g. www.informatics.jax.org/allele/MGI:97490
The text was updated successfully, but these errors were encountered:
allaway
changed the title
consider updating this to identifiers.org resolver to futureproof this
consider updating MGI id to identifiers.org resolver to futureproof this
May 24, 2024
synapse-web-monorepo/packages/synapse-react-client/src/components/GenericCard/Linkify.tsx
Line 43 in 9e4da44
It turns out that while our use case is for the allelle/ path, MGI ids can resolve to lots of different paths like this: https://www.informatics.jax.org/marker/MGI:97490
We should consider changing how this resolves to avoid breaking in the future - e.g. it's possible someone could add an MGI id that does not reference an allele, like MGI:97490, and Synapse would link to the wrong location, e.g. www.informatics.jax.org/allele/MGI:97490
There are a couple of options that would fix this:
Use identifiers.org/MGI:{id}
Use http://www.informatics.jax.org/accession/MGI:{id}
The text was updated successfully, but these errors were encountered: