Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Tests #49

Closed
marvhus opened this issue Oct 16, 2022 · 2 comments · Fixed by #47
Closed

Making Tests #49

marvhus opened this issue Oct 16, 2022 · 2 comments · Fixed by #47
Assignees
@marvhus
Labels
enhancement New feature or request hacktoberfest-accepted help wanted Extra attention is needed

Comments

@marvhus
Copy link
Contributor

marvhus commented Oct 16, 2022 •
edited
Loading

Currently in progress in the #47 pr and in the tests branch.

This is so we can more easily make sure the ciphers produce the expected output.

It would be awesome if people could help making some tests.
Just make sure you notify what ciphers you are making the tests for,
and make a pr into the tests branch when you work on your test.
A good trick is to make the pr as a draft when you start working on it,
then ask for a review when it is done.

Comment on this issue, and we can add you as an assignee,
that way we know who is interested in helping with this.
@marvhus marvhus added enhancement New feature or request help wanted Extra attention is needed hacktoberfest-accepted labels Oct 16, 2022
@marvhus marvhus self-assigned this Oct 16, 2022
@marvhus marvhus moved this to 🏗 In progress in Cryptex V:1.0.0 Pumpkin Patch Oct 16, 2022
@marvhus marvhus linked a pull request Oct 16, 2022 that will close this issue
add tests #47
Merged
@marvhus marvhus mentioned this issue Oct 16, 2022
Merged
@ghost
Copy link

ghost commented Oct 17, 2022 •
edited by ghost
Loading

States pull 47 will close issue 49. As such I'll close with comment subject to re-opening.

• Shepherd | QA

@ghost ghost closed this as completed Oct 17, 2022
@marvhus marvhus reopened this Oct 17, 2022
@marvhus
Copy link
Contributor Author

marvhus commented Oct 17, 2022 •
edited
Loading

This is still in progress at pr #47

@marvhus marvhus pinned this issue Oct 17, 2022
@marvhus marvhus moved this from 🏗 In progress to ✅ Complete in Cryptex V:1.0.0 Pumpkin Patch Oct 31, 2022
@marvhus marvhus closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvhus marvhus

Labels
enhancement New feature or request hacktoberfest-accepted help wanted Extra attention is needed
Projects
No open projects
Cryptex V:1.0.0 Pumpkin Patch
Status: ✅ Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tests SaintsSec/Cryptex
1 participant
@marvhus