Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptex Translate function is broken #65

Closed
AlexKollar opened this issue Oct 28, 2022 · 14 comments
Closed

Cryptex Translate function is broken #65

AlexKollar opened this issue Oct 28, 2022 · 14 comments
Labels
bug Something isn't working Cryptex v1.0.0 Issues slated for Cryptex 1.0.0 good first issue Good for newcomers hacktoberfest-accepted

Comments

@AlexKollar
Copy link
Collaborator

image

@AlexKollar AlexKollar added bug Something isn't working good first issue Good for newcomers hacktoberfest-accepted Cryptex v1.0.0 Issues slated for Cryptex 1.0.0 labels Oct 28, 2022
@marvhus
Copy link
Contributor

marvhus commented Oct 28, 2022

If this is what I think it is,
then I fixed this in the beta branch.
So either

  • wait for the 1.0.0 merge in a few days
  • download the requirements.txt and install the correct bersion of the package
  • or switch over to the beta branch.

If that isn't the issue, then use the -lang flag to list the languages, and check if the iinputed language is correct.

@AlexKollar
Copy link
Collaborator Author

This was on beta branch. 😉

@marvhus
Copy link
Contributor

marvhus commented Oct 28, 2022

This was on beta branch. 😉

Ah ok, then run python3 -m pip install -r requirements.txt in the root of the beta branch

@AlexKollar
Copy link
Collaborator Author

Yeah, still popping errors after:

  • git pull
  • requirements install
  • reinstall of cryptex.

Its odd. Might have something to do with the controller code.

@marvhus
Copy link
Contributor

marvhus commented Oct 28, 2022

Have you checked the list of languages supported by using the -lang flag?
and checked if the one you entered is correct?

@AlexKollar
Copy link
Collaborator Author

@marvhus,
I did a straight copy paste between the example code (Modified to run with cryptex installed and aliased) on beta branch and I got this error.

image

As far as I can tell this is the only existing error still in the code.

@marvhus
Copy link
Contributor

marvhus commented Oct 31, 2022

@marvhus,
I did a straight copy paste between the example code (Modified to run with cryptex installed and aliased) on beta branch and I got this error.

image

As far as I can tell this is the only existing error still in the code.

are you doing this with the updated google translate package?

@AlexKollar
Copy link
Collaborator Author

I did a full re-install of Cryptex as a means of testing the installer for release.
Let me go back and see about updating translate. I kinda figured it would pull the latest when I did the install but I could be wrong.

@AlexKollar
Copy link
Collaborator Author

Yeah no, after doing an update to translate (Which said it was current) no change in error.

@marvhus
Copy link
Contributor

marvhus commented Oct 31, 2022

@AlexKollar run this command:

python3 -m pip show translate

@AlexKollar
Copy link
Collaborator Author

@AlexKollar run this command:

python3 -m pip show translate

image

@marvhus
Copy link
Contributor

marvhus commented Oct 31, 2022

@AlexKollar
run this command

python3 -m pip install googletrans==3.1.0a0

then try using the cipher again

@AlexKollar
Copy link
Collaborator Author

image

Ayeeeee, it works!

@marvhus
Copy link
Contributor

marvhus commented Oct 31, 2022

This is an issue that was fixed in #47, but hasnt been merged yet

@marvhus marvhus moved this to ✅ Complete in Cryptex V:1.0.0 Pumpkin Patch Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cryptex v1.0.0 Issues slated for Cryptex 1.0.0 good first issue Good for newcomers hacktoberfest-accepted
Projects
No open projects
Status: Complete
Development

No branches or pull requests

2 participants