Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Blocked einstein request not handled gracefully #947

Closed
ecRobertEngel opened this issue Jan 27, 2023 · 1 comment · Fixed by #970
Closed

[BUG] Blocked einstein request not handled gracefully #947

ecRobertEngel opened this issue Jan 27, 2023 · 1 comment · Fixed by #970
Assignees
Labels
Acknowledged Team has responded to issue

Comments

@ecRobertEngel
Copy link
Contributor

ecRobertEngel commented Jan 27, 2023

Summary

As Einstein requests are not proxied anymore the requests now go directly to cquotient and they are exposed to ad-blockers again. As many ad-blockers block the domain by default it is important to handle rejected requests gracefully.

Right now we have the following issues:

  • Errors logged to console: Uncaught (in promise) TypeError: Network request failed
  • Recommendation sliders to stay in isLoading state

Steps To Reproduce

  1. Enable an ad-blocker (e.g. ublock-origin)

  2. Go to https://pwa-kit.mobify-storefront.com/

  3. Check console.

  4. Enable an ad-blocker (e.g. ublock-origin)

  5. Go to https://pwa-kit.mobify-storefront.com/global/en-GB/product/25695392M

  6. Check console.

  7. Check the recommendation sliders

Expected result

  • Recommendation sliders should be hidden

Actual result

Describe what actually happened.

System Information (as applicable)

Browser:
Node version:
pwa-kit version:
Desktop OS:
Mobile Device Info:

Additional information

Feel free to attach a screenshot.

@vcua-mobify
Copy link
Contributor

Hi @ecRobertEngel , thanks for notifying us of this issue with ad blockers and for submitting #948. We'll review and follow up on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
3 participants