Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ftp-deploy-sync-state.json during sync process #341

Open
jakludev opened this issue Dec 6, 2022 · 3 comments
Open

Update .ftp-deploy-sync-state.json during sync process #341

jakludev opened this issue Dec 6, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jakludev
Copy link

jakludev commented Dec 6, 2022

Bug Description
Please implement and option to auto update uploaded items to .ftp-deploy-sync-state.json and add parameter to change how often to update the json, so when the process due to random FTP or sync error fails, it stays saved for the next time. Currently if this happens, you can't upload items, because it might fail every time. There would be also timeout error, large amount of items stops or etc.

I need to push Drupal 9 with vendor and composer and its not possible without this feature, so i must copy vendor manually and then sync just some files and its pretty slow method, thanks :-)

on: push
name: 🚀 Deploy website on push
jobs:
web-deploy:
name: 🎉 Deploy
runs-on: ubuntu-latest
steps:
- name: 🚚 Get latest code
uses: actions/checkout@v2
- name: 📂 Sync web
uses: SamKirkland/FTP-Deploy-Action@4.3.2
with:
server: ${{ secrets.FTP_IP }}
username: ${{ secrets.FTP_USER }}
password: ${{ secrets.FTP_PASS }}
server-dir: ./
autoupdate: true, # add this, so it stays optional for other users
autoupdate-items: 150 # add this, so you can change when to autoupdate json
local-dir: ./
protocol: ftp
port: 21
exclude: |
/.git
/.git/

/node_modules/
/db_backup/
/web/core/
/vendor/

@jv-k
Copy link

jv-k commented Dec 7, 2022

I just came across this issue today, with a large first-time upload failing after the mid point due to the host's DNS settings, and FTP-Deploy-Action doesn't update .ftp-deploy-sync-state.json even after uploading thousands of files, after throwing Error: The operation was canceled

It would be great to update the state file at certain upload intervals so that the upload can continue off, great idea!

@reactmore
Copy link

if sync files .ftp-deploy-sync-state.json can be updated together with when the process is running is will be greate

This is not suitable for uploading large files I use codeigniter 4 it takes a long time using the exclude feature to upload files a little bit and I gave up on uploading thirdparty vendors and replaced the code with composer

@SamKirkland SamKirkland added the enhancement New feature or request label Mar 16, 2023
@NearlyShake
Copy link

Same problem here with complete WordPress folder for uploading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants