Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary folder: fittrackee/dist ? #199

Closed
gorgobacka opened this issue Jun 28, 2022 · 2 comments
Closed

Unnecessary folder: fittrackee/dist ? #199

gorgobacka opened this issue Jun 28, 2022 · 2 comments

Comments

@gorgobacka
Copy link
Contributor

While checking and trying to understand the codebase, I was wondering, if the folder "fittrackee/dist" needs to be checked into git, because it can be created on the fly.

Btw: the Makefile points to rm -rf dist/ and .gitignore to /dist instead of fittrackee/dist.

But maybe I get it wrong here and the folder is needed for something specific.

If it's a stupid request, please excuse me and close it. But I'm excited about the project and plan to contribute in the future. Therefore, I'm looking at the codebase at the moment.

@SamR1
Copy link
Owner

SamR1 commented Jun 29, 2022

Hi,

fittrackee/dist contains static assets present in the package available on PyPI. The client part is a single-page application directly served by Flask.
dist is a temporary directory used to generate the package with Poetry.

It's not a common architecture, but for now it eases installation and limits requirements (no javascript tool needed to install FitTrackee on production, from PyPI or by cloning the repo).
Since there is no specific configuration for the client part, it's not mandatory to build assets for a given configuration.

But there are some disadvantages for development (see the contribution guide).
Maybe I should organize the project differently.

And no problem if you have other questions :). You can also reach me on Matrix: #fittrackee:matrix.org

@gorgobacka
Copy link
Contributor Author

Ok. Thanks for your explanations. Then it makes den sense to keep the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants