-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Babel 7 #21
base: master
Are you sure you want to change the base?
Support Babel 7 #21
Conversation
Since this breaks compat with Babel <7, perhaps a major version bump is in order? Not sure what is up with the Travis failures - it seems to be running off master instead of my branch. |
I misread the Travis log. Test failures actually appears to be avajs/eslint-plugin-ava#253. It's fixed in |
Ah, but latest Ava (>=2.0) drops support for Node <8 too. @SamVerschueren does Node 6 support still matter to this project, or is it just a holdover? I am tempted to just drop support here too, which would simplify things. |
Side note: thanks to Babel 7's project-wide configuration, I believe this also kind of fixes #9 (assuming your project has a |
I'd love to see these changes merged; I have a case where babel 7 isn't transpiling a few of my dependencies, and this package fixes it if I use the patched version here. 👍 |
Looks like this is not getting merged. @gavinsharp is there a way in which I can use your version directly? |
@SamVerschueren Can we get this merged please? Thank you for your work on this plugin, would love to continue using it! |
This adds support for Babel 7 (fixes #16), by upgrading the two relevant packages (
babel-core
->@babel/core
andbabel-preset-env
->@babel/preset-env
).This was surprisingly easier than I expected!
I ran into an issue running tests (perhaps because I'm using a newer version of
ava
?), so I had to add a config to ignore thefixtures/
files.I've tested this with our internal app and it works great.