-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: build: Update TizenRT to 2.0_Public_M2 #1780
Closed
rzr
wants to merge
2
commits into
jerryscript-project:master
from
TizenTeam:sandbox/rzr/tizenrt/review/master
Closed
WIP: build: Update TizenRT to 2.0_Public_M2 #1780
rzr
wants to merge
2
commits into
jerryscript-project:master
from
TizenTeam:sandbox/rzr/tizenrt/review/master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
2 times, most recently
from
October 22, 2018 16:40
c0fbcb2
to
4f98356
Compare
This was referenced Oct 22, 2018
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 5, 2018 15:46
4f98356
to
8f7bf9f
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Because current version of TizenRT in IoT.js docker image is oudated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. Use iotjs's defconfig as default config instead of file: "tizenrt_release_config" from container: https://hub.docker.com/r/iotjs/ubuntu/ Is this file tracked anywhere? Later debug, release configs can tracked in IoT.js's source tree, and used as desired, for performance benchmarking. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgrade IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 5, 2018 16:29
8f7bf9f
to
f0744ce
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 5, 2018 16:38
f0744ce
to
cc60c36
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 5, 2018 17:11
cc60c36
to
e8a439c
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 5, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 7, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to rzr/iotjs
that referenced
this pull request
Nov 8, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 8, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 9, 2018 09:53
e8a439c
to
e569f88
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources. File "config/tizenrt/release/artik05x/configs/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 9, 2018 11:19
e569f88
to
d0c5faa
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 9, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
I am rebasing on upstream, I plan to get patches merged one per one: 1st in serie is: |
yichoi
pushed a commit
that referenced
this pull request
Nov 12, 2018
Before updating TizenRT in build script, I thought I would be better to maintain config files in sources' dir. File "config/tizenrt/artik05x/configs/release/defconfig" is coming from "tizenrt_release_config" in travis build container: https://hub.docker.com/r/iotjs/ubuntu/ (I don't know if this file is tracked elsewhere ?) Then debug file was aligned to "release" one, with debug flags enabled. Debug config has just been renamed, and script path adjusted. Note for later, it would make sense to align both after upgrade. Relate-to: #1780 Credit-to: iotjs <https://hub.docker.com/u/iotjs/> IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 12, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 12, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 12, 2018 09:42
d0c5faa
to
bca9381
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 12, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 13, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 15, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to rzr/iotjs
that referenced
this pull request
Nov 15, 2018
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 15, 2018 09:10
bca9381
to
e9b9a5f
Compare
Align to TizenRT's default config, but disable SSS for ARTIK053 also preserve debug options for debug configuration. Bug: jerryscript-project#1777 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/tizenrt/review/master
branch
from
November 20, 2018 14:46
e9b9a5f
to
453931a
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Nov 20, 2018
Align to TizenRT's default config, but disable SSS for ARTIK053 also preserve debug options for debug configuration. Because current version of TizenRT in IoT.js docker image is outdated, let's fetch tag from upstream at build time, to speed up build time, this part can be eventually removed if image is updated with latest TizenRT's sources. jerryx extra lib has been dropped for now, this should be reintroduced later (once TizenRT upgraded IoT.js ?) Bug: jerryscript-project#1777 Forwarded: jerryscript-project#1780 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
Or if you prefer the same changes in single squashed commit: |
already in with squashed pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because current version of TizenRT in IoT.js docker image is oudated,
let's fetch tag from upstream at build time,
to speed up build time, this part can be eventually removed
if image is updated with latest TizenRT's sources.
Use iotjs's defconfig as default config instead of file:
"tizenrt_release_config"
from container:
https://hub.docker.com/r/iotjs/ubuntu/
Is this file tracked anywhere?
Later debug, release configs can tracked in IoT.js's source tree,
and used as desired, for performance benchmarking.
jerryx extra lib has been dropped for now,
this should be reintroduced later (once TizenRT upgrade IoT.js ?)
Bug: #1777
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com