Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we need an npm module for this? #1

Open
SanderElias opened this issue Dec 18, 2017 · 6 comments
Open

do we need an npm module for this? #1

SanderElias opened this issue Dec 18, 2017 · 6 comments

Comments

@SanderElias
Copy link
Owner

I'm doubting if there is a need to build an NPM module for what is essentially 1 file.

If you are interested in this, please vote in this issue.

@cyrilletuzi
Copy link

cyrilletuzi commented Dec 18, 2017

Amazing idea! Why not a PR in Angular?

@SanderElias
Copy link
Owner Author

For now, I'm pretty sure this is something the core team feels this is more of a userland solution.
And also, this is completely unneeded if you go full observables and utilize the async pipe.

@niklas-dahl
Copy link

Most npm modules are essentially 1 file, this is usefull so please put it on npm :)

@dereklin
Copy link

@SanderElias @cyrilletuzi
I was thinking this could be part of Angular. Can the component decorator be enhanced to do:

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css'],
  unsubscribeOnDestroy: true
})

OR

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css'],
  onDestroyBehaviors: [UtilDestroy]
})

@Carniatto
Copy link

@SanderElias Amazing clean code, I love it! please do an npm pkg so I can start using already :)

@SanderElias
Copy link
Owner Author

Ok, I will add it as an NPM package to my sample repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants