Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map display #46

Closed
Turtyo opened this issue Jan 18, 2024 · 5 comments · Fixed by #58
Closed

Map display #46

Turtyo opened this issue Jan 18, 2024 · 5 comments · Fixed by #58
Assignees
Labels
confirmed Has been approved to make code based on this new feature Ask for a new feature
Milestone

Comments

@Turtyo
Copy link
Collaborator

Turtyo commented Jan 18, 2024

Feature Description

A visual representation of the map.

Motivation

We have the data structure of the map thanks to #30 but we don't have a display for it. The goal here would be to have a simple visual representation of the map. It doesn't need to be fancy, just some squares and letters for rooms events will do as placeholders, but it is to have the base structure of the map display laid out before making it look good.

Concept art / Designs

map_concept

Acceptance Criteria

  • The map is faithful to the data structure
  • No hard coded display, it needs to adapt depending on map that is given
  • Player can move on the map by clicking (though this might be done later since we don't really have anything to tell where the player is on the map right now)

Proposed Solution

No specific solution, make use of Godot's tool !

Additional Context

This might need the PR that will come from #9 if we want to implement a you see/ you don't see the rooms on the display.

@Turtyo Turtyo added the new feature Ask for a new feature label Jan 18, 2024
@Tysterman74
Copy link
Collaborator

Did we ever merge map-implementation back down to main? I think we may want to make that magic happen first before we start any progress on this Issue.

@Tysterman74
Copy link
Collaborator

In terms of the UI, were we thinking something similar to StS where we have the icon in the top right
image

Where when we click it, it will open up the map full screen?
image

@Turtyo
Copy link
Collaborator Author

Turtyo commented Jan 19, 2024

Seems good to me.
And no we haven't merged the map-implementation into the main yet, for the simple reason that the main doesn't need the map for now. If we merge now and change things later, that's more merge conflicts to solve potentially.

@Tysterman74 Tysterman74 self-assigned this Jan 24, 2024
@Tysterman74
Copy link
Collaborator

From our discussions we had @Turtyo are we okay with leaving the light mechanics out of this issue for now and just focus on getting a display for the map? Then we can save the overlaying of the light in #9?

@Turtyo
Copy link
Collaborator Author

Turtyo commented Jan 24, 2024

Yes, for now we just focus on showing a basic map. The light mechanic can wait for #9 to be implemented. The display may be done at the same time as #9 or separately, but for now we should focus on having a basis before adding more stuff to it.

@Tysterman74 Tysterman74 added the confirmed Has been approved to make code based on this label Jan 24, 2024
@Turtyo Turtyo linked a pull request Feb 2, 2024 that will close this issue
@Turtyo Turtyo added this to the Alpha 1.0 milestone Feb 11, 2024
@Turtyo Turtyo closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Has been approved to make code based on this new feature Ask for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants