New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusion of entry_points looks wrong #1

Closed

llimeht opened this issue Aug 15, 2022 · 0 comments · Fixed by #2

Contributor

llimeht commented Aug 15, 2022

setup.py creates a console script entry_point into the module called sasview pointing at sasdata.loader.Loader:load.

reusing the sasview name is problematic, since that will still be used by the sasview project itself
sasdata.loader.Loader:load doesn't exist, perhaps was intended to be sasdata.dataloader.Loader:load?
loading the data but doing nothing with it probably isn't useful anyway

I'm not sure that this will ever have a command line interface at all, unless it one day grows a scriptable file format conversion utility.

Perhaps the entry_points kwarg to setup should just be deleted?

The text was updated successfully, but these errors were encountered:

krzywon mentioned this issue

Remove entry_point from setup.py #2

Merged

krzywon closed this as completed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment