Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when manipulation center outside the data q-range #22

Open
krzywon opened this issue Sep 16, 2022 · 2 comments
Open

Bug when manipulation center outside the data q-range #22

krzywon opened this issue Sep 16, 2022 · 2 comments

Comments

@krzywon
Copy link
Collaborator

krzywon commented Sep 16, 2022

As noted in SasView/sasview#1346, all manipulations assume the center of averaging should be Q=(0,0). If this is outside the Q range of the data, the manipulation fails.

This could potentially be a two-part ticket. First, the manipulation should not fail when the averaging center is outside the data Q-range. Second, the averaging center should be modifiable and not fixed at the axis origins.

@butlerpd
Copy link
Member

Working on cleanup in preparation for Contributor Camp XII:

@krzywon and @lucas-wilkins is this still true after the Ellis' refactoring? If not then we should close this issue.

@krzywon
Copy link
Collaborator Author

krzywon commented Nov 27, 2023

The work done by @ehewins is still in an open PR: #47. That said, the open PRs are awaiting a functionality review, which might tell us if this ticket has been addressed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants