Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for all data formats that are not in q space (Trac #922) #1005

Closed
butlerpd opened this issue Mar 30, 2019 · 3 comments
Closed
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

!SasView 4.1 still supports at least one data format that is not in q space but in pixel space: the NIST ASC 2D format.

We should remove this as a supported type

Migrated from http://trac.sasview.org/ticket/922

{
    "status": "closed",
    "changetime": "2017-08-22T18:55:20",
    "_ts": "2017-08-22 18:55:20.885111+00:00",
    "description": "!SasView 4.1 still supports at least one data format that is not in q space but in pixel space: the NIST ASC 2D format.\n\nWe should remove this as a supported type",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2017-04-05T13:41:56",
    "component": "SasView",
    "summary": "Remove support for all data formats that are not in q space",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.2.0",
    "owner": "GitHub <noreply@github.com>",
    "type": "defect"
}
@butlerpd butlerpd added this to the SasView 4.2.0 milestone Mar 30, 2019
@butlerpd butlerpd added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2017/08/02 09:36:52: smk78 commented:

Lewis just found a slight complication: the loader averaging unit tests are all set up to use an ASC file!

@sasview-bot
Copy link

Trac update at 2017/08/02 09:42:08: lewis commented:

I've converted the ASC file that the tests were using into NXcanSAS and they're all passing again now

@sasview-bot
Copy link

Trac update at 2017/08/22 18:55:20:

In changeset f001bc9:

#!CommitTicketReference repository="sasview" revision="f001bc9e4b9d1ac0d4712117442f0c949334dbc4"
Merge pull request #323 from lewisodriscoll/ticket-876

Refactor File Loaders - fixes #974 #1027 #940 #962 #1005 #1054 #1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants