Conversion routines for reparameterized models not used in 5.x

[krzywon]

Models that have their model parameters changed in 5.x are not run through the model conversion routines found in sasmodels/convert.py. This is causing a problem with sasmodels PR #458. This conversion is implemented in v4.x master: sasview/pagestate.py.

The conversion methods are available in the main branch but will need to be called while loading a fit project. A good place to do this might be in FittingWidget.updateParamsWithParameters().

[butlerpd]

A related problem just discovered while testing sasmodels #458 is that the project loader no longer loads 4.x projects at all! Instead it reports the error:

19:43:45 - WARNING: ER(...) function ignored. Using radius_effective(mode, ...) instead if it exists.
19:43:45 - ERROR: Error while reading the project file: No module named 'sas.sascalc.dataloader.readers.cansas_reader_HDF5'
19:43:45 - ERROR: Error while converting the project file: local variable 'datasets' referenced before assignment

[krzywon]

@butlerpd Could you attach a project that is failing for you? I've attached a simple sphere fit that I generated using v4.2.2 that loads when running from the sasview main and sasmodels master branches.
save_v4_2_2_sphere.zip

Edit: I tested loading this project using both the BroadPeak model reparameterization branch as well as master and both branches are successful in loading it. Perhaps this is an issue with the broad peak?

[butlerpd]

did you try this with the installer version of main? it may be that there is a dependency issue?

[butlerpd]

This needs to be addressed before the next release or broad peak model may now break things sasmodels#458