Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Slicer for 2D data #2070

Open
JoGaudet opened this issue Jun 15, 2022 · 2 comments · Fixed by #1919
Open

Box Slicer for 2D data #2070

JoGaudet opened this issue Jun 15, 2022 · 2 comments · Fixed by #1919
Labels
Being Tested When an issue is done but not ready to be closed. Enhancement Feature requests and/or general improvements Slicers Concerns slicer functionality

Comments

@JoGaudet
Copy link

The current box slicer option for 2D data visualization is currently constrained such that the center of the box is fixed to the center of the 2D data. It would be better to allow for translation of the box slicer so it can be centered anywhere within the 2D data.

@krzywon
Copy link
Contributor

krzywon commented Jun 15, 2022

Despite the different titles, this request might already be covered by #1344 and #1346. @JoGaudet - Could you take a look at those when you get a chance?

Side note - work is already being done to address some of this in PR #1919 by @butlerpd.

@lucas-wilkins lucas-wilkins added Slicers Concerns slicer functionality Feature Request labels Jul 21, 2022
@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements and removed Feature Request labels Aug 31, 2022
@butlerpd
Copy link
Member

Indeed @krzywon and @JoGaudet, this should be fixed already in PR #1919. There remain a few other things that need to be fixed, including documentation (and the fix to issue #2482 which is mostly complete as well and should be submitted as a PR soon) before it is ready to merge. However it might be useful to test out the code from branch SlicerExtension_1344 to see if it addresses the intended use cases.

@jack-rooks jack-rooks added the Being Tested When an issue is done but not ready to be closed. label Jan 30, 2024
@jack-rooks jack-rooks linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Being Tested When an issue is done but not ready to be closed. Enhancement Feature requests and/or general improvements Slicers Concerns slicer functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants