Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give files in test folder descriptive names #2093

Open
lucas-wilkins opened this issue Jun 17, 2022 · 2 comments · Fixed by #2148
Open

Give files in test folder descriptive names #2093

lucas-wilkins opened this issue Jun 17, 2022 · 2 comments · Fixed by #2148
Labels
Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Requires Community Coding Effort Issues that require a collaborative coding effort to resolve correctly

Comments

@lucas-wilkins
Copy link
Contributor

Example files should have descriptive names.

This probably means checking that they are not used by tests, and changing the references to them too.

See also SasView/tutorials#13

@lucas-wilkins lucas-wilkins added Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Requires Community Coding Effort Issues that require a collaborative coding effort to resolve correctly labels Jun 17, 2022
@smk78
Copy link
Contributor

smk78 commented Jun 17, 2022

In principle I agree @lucas-wilkins . The problem is that some filenames would then get rather long...

What we do have, however, is this:
https://www.sasview.org/docs/user/sasview/test/testdata_help.html

@dehoni: Could you update this document with your latest additions, please? Thanks.

@dehoni
Copy link
Contributor

dehoni commented Jun 22, 2022

In principle I agree @lucas-wilkins . The problem is that some filenames would then get rather long...

What we do have, however, is this: https://www.sasview.org/docs/user/sasview/test/testdata_help.html

@dehoni: Could you update this document with your latest additions, please? Thanks.

The coordinate files that have been created for the GSC examples have been added to the testdata list in branchhttps://github.com/SasView/sasview/tree/add-magnetic-test-files

@dehoni dehoni linked a pull request Aug 16, 2022 that will close this issue
@lucas-wilkins lucas-wilkins reopened this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Requires Community Coding Effort Issues that require a collaborative coding effort to resolve correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants